[MDEV-10194] CACHE_LINE_SIZE malloc align Created: 2016-06-08 Updated: 2018-05-17 Resolved: 2018-05-17 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB, Storage Engine - XtraDB |
| Fix Version/s: | N/A |
| Type: | Task | Priority: | Major |
| Reporter: | Sergey Vojtovich | Assignee: | Sergey Vojtovich |
| Resolution: | Incomplete | Votes: | 0 |
| Labels: | contribution, foundation | ||
| Issue Links: |
|
||||||||
| Sprint: | 10.2.4-2 | ||||||||
| Comments |
| Comment by Daniel Black [ 2016-06-15 ] |
|
replaced PR-180 with a single commit removing already merged code. |
| Comment by Sergei Golubchik [ 2016-10-09 ] |
|
note that while cmake does detect cache line size currently (in 10.2) this value seems to be ignored by the following build |
| Comment by Daniel Black [ 2017-05-29 ] |
|
Ok. Looking at this. Sorry for missing previous comment |
| Comment by Sergey Vojtovich [ 2017-08-02 ] |
|
PR reviewed, many changes requested. |
| Comment by Sergey Vojtovich [ 2018-05-17 ] |
|
Many InnoDB singletons are now allocated statically, paddings were replaced with alignment. There're just a few simple exceptions in srv0conc.cc, btr0sea.cc, ut0counter.h. I'm closing this task for now as there was no feedback since quite a while. If you still plan to improve this, please try improving them separately: smaller patches are much simpler to discuss and thus they have higher chances to get merged. |