[MDEV-10189] Write warning in error log if option is set in configuration files multiple times Created: 2016-06-08  Updated: 2023-10-12

Status: Open
Project: MariaDB Server
Component/s: None
Fix Version/s: None

Type: Task Priority: Minor
Reporter: Geoff Montee (Inactive) Assignee: Unassigned
Resolution: Unresolved Votes: 2
Labels: cnf, configuration, variable


 Description   

When a user's configuration file has an !includedir directive and the user has accidentally set an option multiple times in multiple files, a lot of the time the user doesn't even notice until things aren't working as they expect them to. This is more often true for users who use our enterprise packages, since mariadb-enterprise.cnf sets a bunch of common options.

If an option is set multiple times in configuration files, it would be great if some kind of warning similar to the following could be printed to the error log:

[Warning] Option 'binlog_format' set multiple times in configuration files. Using the last value read from file 'z.cnf'. Using value 'MIXED'.



 Comments   
Comment by Sergei Golubchik [ 2016-06-10 ]

Having one option in many files is quite normal and common. I'm not great fan of issuing warnings for a valid and documented use of a feature just because someone somewhere might use it by mistake and get unexpected resulst (hi, gcc!).

May be only as a note or only for high values of @@log_warnings... But then it won't serve its purpose — it won't help unexperienced users. Those who know how to increase the log verbosity, they also know that an option may be present in many files and they know how to use mysqld --help --verbose and my_print_defaults --mysqld.

Comment by Chris Calender (Inactive) [ 2016-06-10 ]

The purpose is not just for "unexperienced users". What about experienced users trying to quickly solve problems for customers, for instance? With more and more config files (mariadb-enterprise.cnf, tokudb.cnf, galera.cnf,...) and locations (...), I personally think this is an excellent request.

I'm fine with it being logged for log_warnings=2+, fwiw. I really like that approach.

Thank you for your consideration.

Comment by Sergei Golubchik [ 2016-06-10 ]

Experienced users can run my_print_defaults --mysqld.
But ok, it's a valid feature request.

Comment by Ralf Gebhardt [ 2023-10-12 ]

I have removed the fixVersion for this task as it is one of 5.5, 10.1, 10.2, 10.3, which are EOLed.

Please add a new fixVersion if you plan to work on this task for a not EOLed versions.

Generated at Thu Feb 08 07:40:20 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.