[MDEV-10100] main.pool_of_threads fails sporadically in buildbot Created: 2016-05-22 Updated: 2017-01-04 Resolved: 2017-01-04 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Tests |
| Affects Version/s: | 10.0, 10.1, 10.2 |
| Fix Version/s: | 5.5.55, 10.0.29, 10.1.21, 10.2.4 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Elena Stepanova | Assignee: | Elena Stepanova |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
http://buildbot.askmonty.org/buildbot/builders/p8-trusty-bintar/builds/1030/steps/test/logs/stdio
|
| Comments |
| Comment by Elena Stepanova [ 2016-12-31 ] | |||||||||||||
|
Copied from
It is a different problem from the one in the description, but they have to be solved together. | |||||||||||||
| Comment by Elena Stepanova [ 2016-12-31 ] | |||||||||||||
|
The failure in the comment above happens on very slow builders and/or in the conditions which make them even slower (such as parallel runs on a valgrind builder). The reason is that the test config has this:
If everything is really slow, client connections are too, and MTR simply cannot establish the initial connection. The failure in the description also happens on slow builders, but the slowness here plays an opposite role. This part of the test does the following: So, in one failure the immediate problem is too short connect_timeout, while in another problem it's too long connect_timeout. That's why they need to be solved together. | |||||||||||||
| Comment by Elena Stepanova [ 2017-01-01 ] | |||||||||||||
|
wlad, please review the patch. https://github.com/MariaDB/server/commit/b1165b0dd35a1dbd24337056b6b074448fa4e046 The commit comment is bigger than the patch itself, but I thought it needed to be explained. The change passed a buildbot round on my tree, but I'd like you to check that I haven't lost any of the initially designed test logic by re-arranging the fragments. | |||||||||||||
| Comment by Vladislav Vaintroub [ 2017-01-01 ] | |||||||||||||
|
Looks reasonable, ok to push. made a tiny suggestion to fix a comment in the .test file. | |||||||||||||
| Comment by Elena Stepanova [ 2017-01-01 ] | |||||||||||||
|
Thanks. | |||||||||||||
| Comment by Elena Stepanova [ 2017-01-04 ] | |||||||||||||
|
The second problem happens on 5.5 too, need to backport the fix there as well https://github.com/MariaDB/server/commit/e5d7fc967ede53407a65bfde3faec3181e35f19f |