[MDBF-565] RPM package build output cleanup Created: 2023-05-23  Updated: 2023-05-26

Status: Open
Project: MariaDB Foundation Development
Component/s: Buildbot
Affects Version/s: N/A
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Vlad Bogolin Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 0.25d
Original Estimate: Not Specified


 Description   

The build output for RPM creation has 100k+ lines (output example), produce a lot of noise in the output. One such example is

 File listed twice: <file>

The build output needs to be cleand up.



 Comments   
Comment by Faustin Lammler [ 2023-05-23 ]

illuusio do you have any idea on what we are doing wrong? Is this something that could be spotted by rpmlint (MDBF-440).

Comment by Tuukka Pasanen [ 2023-05-23 ]

As it says there is same file listed twice in package it means that you have for example dir /etc/mariadb and then you have another place /etc/mariadb/some.conf. After that file is listed twice.

Comment by Vlad Bogolin [ 2023-05-23 ]

illuusio would this than be an environment problem?

Comment by Tuukka Pasanen [ 2023-05-25 ]

Actually no. What 'File listed twice' means can be found behind this link: what does the rpmbuild warning "File listed twice" ACTUALLY MEAN?

Comment by Daniel Black [ 2023-05-26 ]

Warning is generated from rpmbuild. As source files are listed, the source files are duplicates.

This is occuring in the MariaDB-backup build. The obvious part here is that MariaDB backup reuses significant portions of innodb and its included mysys libraries so of course there is duplicated source file.

While rpmbuild has a --quiet option to restrict output to errors. CPackRPM doesn't give an option to append options to rpmbuild. A rpmbuild wrapper in the shell path

#!/bin/sh
/usr/bin/rpmbuild --quiet "$@"

restricts output to:

warning: File listed twice: /usr/src/debug/MariaDB-/src_1/strings
warning: File listed twice: /usr/src/debug/MariaDB-/src_1/strings
warning: File listed twice: /usr/src/debug/MariaDB-/src_1/strings/ctype-uca1400data.h
warning: File listed twice: /usr/src/debug/MariaDB-/src_1/strings/ctype-uca1400data.h
warning: File listed twice: /usr/src/debug/MariaDB-/src_1/strings/ctype-uca1400data.h
warning: File listed twice: /usr/src/debug/MariaDB-/src_1/strings/ctype-uca1400data.h

And eliminates:

    Deprecated external dependency generator is used!
    File listed twice: /usr/src/debug/MariaDB-
    File listed twice: /usr/src/debug/MariaDB-/src_0
    File listed twice: /usr/src/debug/MariaDB-/src_0
    File listed twice: /usr/src/debug/MariaDB-/src_0/client
    File listed twice: /usr/src/debug/MariaDB-/src_0/client
    File listed twice: /usr/src/debug/MariaDB-/src_0/client
    File listed twice: /usr/src/debug/MariaDB-/src_0/client/client_priv.h
    File listed twice: /usr/src/debug/MariaDB-/src_0/client/client_priv.h
    File listed twice: /usr/src/debug/MariaDB-/src_0/client/client_priv.h

So this cuts it down by 1/2, however no elimination is possible without restructuring innodb as a library.

Generated at Thu Feb 08 03:38:48 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.