[MDBF-389] provide timezone data files Created: 2022-04-11 Updated: 2023-04-11 Resolved: 2022-06-17 |
|
| Status: | Closed |
| Project: | MariaDB Foundation Development |
| Component/s: | Downloads |
| Affects Version/s: | N/A |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Daniel Black | Assignee: | Faustin Lammler |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.75d | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Description |
|
Our kb on timezones for Windows does not provide a solution for 10.6+ because the MySQL timezones are incompatible (Offset is a keyword in MariaDB only). Because we now have a mirror service can we generate the timezones sql files here for distribution. Suggestion: A cron job that runs:
The mariadb image is semi frequently updated as its ubuntu base image is also updated, hence bringing with it updated /usr/share/zoneinfo. Also as we do releases and the mariadb-tzinfo-to-sql changes we get that change automatically. |
| Comments |
| Comment by Daniel Black [ 2022-05-23 ] | ||||||||||||||||||||||||||
|
Version portability added by | ||||||||||||||||||||||||||
| Comment by Faustin Lammler [ 2022-05-23 ] | ||||||||||||||||||||||||||
|
Daniel, some questions:
| ||||||||||||||||||||||||||
| Comment by Daniel Black [ 2022-05-25 ] | ||||||||||||||||||||||||||
|
1. propose I'm missing the context of the querstion "propose" asks here. We should put it somewhere, and mirrors seem a more accessible place to update than mariadb.org. 2. testing docker run -e MARIADB_INITDB_SKIP_TZINFO=1 -e MARIADB_ROOT_PASSWORD=bob --rm --name m106test docker.io/library/mariadb:10.6 Weak attempt at a basic timezone test:
3. update granuality https://github.com/docker-library/repo-info/commits/master/repos/ubuntu/remote/20.04.md seems to be few months http://changelogs.ubuntu.com/changelogs/pool/main/t/tzdata/tzdata_2022a-0ubuntu0.20.04/changelog also very sparotic if we did apt-get update && apt-get install tzdata as part of the cron job. Or go to the source {{curl -L --etag-save tzdata.etag -o tzdata-latest.tar.gz https://www.iana.org/time-zones/repository/tzdata-latest.tar.gz But monthly from ubuntu updates seems ok. 4. gzip Does window support gzip well now? Thought old ZIP might be ok though. | ||||||||||||||||||||||||||
| Comment by Daniel Black [ 2022-06-01 ] | ||||||||||||||||||||||||||
|
tested with:
Having "use mysql;" at the top of the sql file is probably useful to avoid use errors. Without timezones loaded, immediate errors occur:
| ||||||||||||||||||||||||||
| Comment by Daniel Black [ 2022-06-01 ] | ||||||||||||||||||||||||||
|
Can also be tested on < 10.6 version:
Tested also that a syntax error in zoneinfo.sql will cause the container not to start. | ||||||||||||||||||||||||||
| Comment by Daniel Black [ 2022-06-06 ] | ||||||||||||||||||||||||||
| Comment by Faustin Lammler [ 2022-06-06 ] | ||||||||||||||||||||||||||
|
Thanks danblack. This has been merged and rewritten a bit (improve logging mechanism and error handling mainly and adapt PATH for production). | ||||||||||||||||||||||||||
| Comment by Faustin Lammler [ 2022-06-07 ] | ||||||||||||||||||||||||||
|
danblack the zoneinfo file is now replicated on the fi mirror (under our control), this is the only mirror serving the file until we put it on netcologne and osuosl with dbart. Next time the docker container is updated, I would like to verify that the whole process is working good. I switch the script to using podman instead of docker and I hit a nice bug in conman, so I have added another check. You can probably have a look when you have time, it's almost finished I guess: | ||||||||||||||||||||||||||
| Comment by Daniel Black [ 2022-06-09 ] | ||||||||||||||||||||||||||
|
Looks good. Thanks. Welcome to the use of podman too. (I was too, just had docker=podman alias, and a newer version that avoided the bug). It occurred to me maybe zonedata_old.zip is a better filename for the old version. Production scripts in home directories doesn't look great either. I'm really happy we have a solution now. | ||||||||||||||||||||||||||
| Comment by Faustin Lammler [ 2022-06-09 ] | ||||||||||||||||||||||||||
|
> It occurred to me maybe zonedata_old.zip is a better filename for the old version. You mean zoneinfo_old.zip, should we keep it then? > Production scripts in home directories doesn't look great either. Yep, fully agree on that, it's already on my TODO list to add a proper sync user for the mirror machine but it will have to wait a bit since it depends on other task. |