[MCOL-985] buildAggregateColumn needs to handle error code Created: 2017-10-24  Updated: 2017-10-30  Resolved: 2017-10-30

Status: Closed
Project: MariaDB ColumnStore
Component/s: MDB Plugin
Affects Version/s: 1.0.12
Fix Version/s: 1.0.12

Type: Bug Priority: Minor
Reporter: David Hall (Inactive) Assignee: Andrew Hutchings (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2017-21, 2017-22

 Description   

In ha_calpont_execplan.cpp in function buildAggregateColumn around line 3608, there is this code:
else

{ rc = buildReturnedColumn(ord_col, gwi, gwi.fatalParseError); }

It needs to check the return code rc and the fatalParseError flag:

else
{
rc = buildReturnedColumn(ord_col, gwi, gwi.fatalParseError);
if (!rc || gwi.fatalParseError)

{ return NULL; }

}

 Comments   
Comment by David Hall (Inactive) [ 2017-10-24 ]

There's no need to send to QA as there's currently no test case that breaks from this code.

Comment by Andrew Hutchings (Inactive) [ 2017-10-30 ]

Not sent to QA as requested.

Generated at Thu Feb 08 02:25:18 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.