[MCOL-956] Customer changes to my.cnf be preserved during upgrade Created: 2017-10-04 Updated: 2021-04-19 Resolved: 2020-10-28 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | N/A |
| Affects Version/s: | None |
| Fix Version/s: | N/A |
| Type: | New Feature | Priority: | Major |
| Reporter: | David Hill (Inactive) | Assignee: | Jose Rojas (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Sprint: | 2018-16, 2018-17, 2018-18, 2018-19, 2018-20, 2018-21, 2019-01, 2019-02, 2019-03, 2019-04, 2019-05, 2019-06, 2020-1, 2020-2, 2020-3, 2020-4, 2020-5, 2020-6, 2020-7 | ||||||||||||
| Description |
|
Customer request that changes that they make to the my.cnf be preserved during upgrade. Currently we required them to make these manually. |
| Comments |
| Comment by Patrick LeBlanc (Inactive) [ 2018-11-27 ] |
|
This looks at least half-redundant with Currently, the user has the ability to specify fields they want to include across upgrades, but no way to exclude fields across upgrades. I'm not sure how important excluding them is. Technically there are myCnf-include-args.text and myCnf-exclude-args.text files which they use to specify both, but the exclude one isn't actually used in the code. |
| Comment by David Hall (Inactive) [ 2020-10-27 ] |
|
For 1.4+, we currently save off columnstore.cnf, but don't restore it. MariaDB keeps all other .cnf files intact, expecting the user to make any new changes needed, but it preserves all user changes. We should exhibit the same behavior. |
| Comment by Jose Rojas (Inactive) [ 2020-10-28 ] |
|
After further investigation, columnstore acts as mariadb does in regards to preserving config files During minor upgrade (e.g., 10.5.5 to 10.5.6 via yum upgrade *newpackage) columnstore preserves columnstore.cnf, just like mariadb preserves mariadb-enterprise.cnf During major upgrade (e.g., 10.4 to 10.5 via yum uninstall *oldpackage && yum install *newpackage) columnstore preserves columnstore.cnf as columnstore.cnf.rpmsave, just like mariadb preserves mariardb-enterprise.cnf as mariadb-enterprise.cnf.rpmsave Closing this issue, as the goal is to keep things as consistent with mariadb as possible |