[MCOL-849] Process Manager leaving files called '+' lying around Created: 2017-08-01  Updated: 2020-08-25  Resolved: 2017-08-16

Status: Closed
Project: MariaDB ColumnStore
Component/s: ProcMgr
Affects Version/s: 1.0.10, 1.1.0
Fix Version/s: 1.0.11, 1.1.0

Type: Bug Priority: Major
Reporter: Andrew Hutchings (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 2
Labels: None

Sprint: 2017-16

 Description   

processmanager.cpp line 6248 (develop-1.0) has the following:

string cmd = startup::StartUp::installDir() + "/bin/reset_locks " + skip + " > + logdir + /reset_locks.log1 2>&1";

The first pipe direction character should have a closing quote mark and file name should have an opening quote mark. Since it does not the log goes into a file called '+' in the current working directory.

 Comments   
Comment by David Hill (Inactive) [ 2017-08-09 ]

fixed in develop-1.0 1.0.11

commit 06199595763c363dc36a6bd8d1c1d52a1eb2071c
Author: David Hill <david.hill@mariadb.com>
Date: Wed Aug 9 13:53:54 2017 -0500

Comment by David Hill (Inactive) [ 2017-08-09 ]

1.1.0 merged from 1.0.10

commit 76fb89c13f8e1495e127078474f315850d5b86ea
Merge: 42867bc 6ed975d
Author: David Hill <david.hill@mariadb.com>
Date: Wed Aug 9 16:01:38 2017 -0500

Comment by David Hill (Inactive) [ 2017-08-16 ]

a file called + will show up in $HOME after as ma stopSystem.

to test, do a startsystem and stopsystem and make sure that a file called + doesnt exist in $HOME, /root for root install

Comment by Daniel Lee (Inactive) [ 2017-08-16 ]

Builds verified: 1.0.11-1 and 1.1.0 (GitHub source)
/root/columnstore/mariadb-columnstore-server
commit 6ed33d194819aaa5f2521c888639f44546fb7ce2
Merge: 97284ea 770537e
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Thu Aug 3 20:54:13 2017 +0100
Merge pull request #66 from mariadb-corporation/MCOL-684
MCOL-684 call fix_fields for parameters in PREPARED statements
/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit d9233bde4932bd8d621888e33a38f34c181445b4
Author: David Hill <david.hill@mariadb.com>
Date: Tue Aug 15 20:41:26 2017 +0000
moved CONFIGURE option to bottom of list
diff --git a/oam/oamcpp/liboamcpp.h b/oam/oamcpp/liboamcpp.h
index 6b24a30..8c0e3ed 100644
— a/oam/oamcpp/liboamcpp.h
+++ b/oam/oamcpp/liboamcpp.h
@@ -558,7 +558,6 @@ namespace oam
HEARTBEAT_SEND,
PROCBUILDSYSTEMTABLES,
LOCALHEARTBEAT,
CONFIGURE,
RECONFIGURE,
PROCESSRESTART,
GETSOFTWAREINFO,
@@ -580,7 +579,8 @@ namespace oam
MASTERDIST,
DISABLEREP,
PROCGLUSTERASSIGN,
PROCGLUSTERUNASSIGN
+ PROCGLUSTERUNASSIGN,
+ CONFIGURE
};

Generated at Thu Feb 08 02:24:16 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.