[MCOL-750] make the remote server install scripts run faster by checking for ssh/scp return codes Created: 2017-06-06  Updated: 2023-10-26  Resolved: 2017-10-23

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.1.0
Fix Version/s: 1.1.1

Type: New Feature Priority: Trivial
Reporter: David Hill (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

multi-node systems


Sprint: 2017-12, 2017-13, 2017-14, 2017-19, 2017-20, 2017-21

 Description   

A change was made to the remote_command.sh script for MCOL-723 that made it return faster to the caller by adding a check for return codes from ssh and adding 'ssh -v' option.

The same changes need to be applied to the other installer scripts to make the install and addModule functions faster.

These scripts will be changed:

user_installer.sh
performance_installer.sh
binary_installer.sh



 Comments   
Comment by David Hill (Inactive) [ 2017-06-30 ]

code part of the MCOL-770 branch pull request

Comment by David Hill (Inactive) [ 2017-07-05 ]

still doing some develop testing before hand off to QA

Comment by David Hill (Inactive) [ 2017-07-05 ]

for testing, do the same multi-node install and addmodule. The postConfigure remote scripts and the addmodule command will be faster due to the scripts that setup the remote node are doing less and have better command completion checks.

Comment by Daniel Lee (Inactive) [ 2017-07-06 ]

Build tested: Github source 1.1.0

[root@localhost mariadb-columnstore-server]# git show
commit 60f2f261f81d994307762d6d93380873513a0be8
Author: david hill <david.hill@mariadb.com>
Date: Tue Jun 20 16:05:32 2017 -0500

[root@localhost mariadb-columnstore-engine]# git show
commit 3601c344ba8eaedb7ed780eab5da4377db361b07
Author: david hill <david.hill@mariadb.com>
Date: Tue Jul 4 03:51:27 2017 -0500

Did not see the performance gain expected when compared to 1.0.9-1. The addmodule for took 96 seconds for 1.0.9-1 and 95 seconds for 1.10.0-1.

Comment by Daniel Lee (Inactive) [ 2017-07-06 ]

It turned out that I did not use the latest build package file (yes, cp error). Tried the test again and addmodule took 45 seconds instead of 96.

Comment by David Hill (Inactive) [ 2017-08-10 ]

original changes seem to destabilize the install, so need some changes.

Comment by David Hill (Inactive) [ 2017-10-02 ]

These changes were made in the 1.1.0 builds...

So just needs to be closed by Daniel, we have tested quite a bit on 1.1.0 beta install testing

Comment by Daniel Lee (Inactive) [ 2017-10-23 ]

Build verified: 1.1.1-1 GitHub source
/root/columnstore/mariadb-columnstore-server
commit 3d846d3277ba970b32ba3f471323fcac58b5c35d
Author: david hill <david.hill@mariadb.com>
Date: Mon Oct 23 09:57:05 2017 -0500
change to 1.1.1
/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 4aa7eb1830ddf585706f804b1982589c7d67ff0a
Author: root <root@srvhill01.lan>
Date: Mon Oct 23 09:56:07 2017 -0500
change to 1.1.1

We did run lots of tests for the 1.1.0-1 beta. I also did one more installation tests with the latest source to make sure it still works.

Generated at Thu Feb 08 02:23:33 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.