[MCOL-733] New module got added to the stack when the addmodule command failed Created: 2017-05-31  Updated: 2023-10-26  Resolved: 2017-09-14

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.0.10, 1.1.0
Fix Version/s: 1.1.0

Type: Bug Priority: Major
Reporter: Daniel Lee (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2017-14, 2017-15, 2017-16, 2017-17, 2017-18

 Description   

Build tested: Github source 1.1.0
commit 349cae544b6bc71910267a3b3b0fa3fb57b0a587
Merge: bd13090 2ecb85c
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Thu May 4 16:06:16 2017 -0500
[root@localhost mariadb-columnstore-engine]# git show
commit 2cc5fc7195a76ce6ff475ba85f67123ec94b9fbe
Author: david hill <david.hill@mariadb.com>
Date: Tue May 30 15:12:50 2017 -0500
I did a non-distributed installation for a 1um2pm stack, the tried to add pm3, using a node that did not have ColumnStore files installed. The addmodule command failed expected. But the getprocessstatus command showed pm3 as part of the stack.

To correct the issue, the user needs to use the removemodule command to remove it.

My understanding is that this issue is not new. If affects existing releases.

OAM should either add the new module to the configuration file upon successful installation, or remove it if installation failed.

 Comments   
Comment by David Hill (Inactive) [ 2017-08-30 ]

fixed in 1.1.0

Added code to do a removeModule command when addModule fails after the module has been configured.

How I tested:
1. to simulate a failure, I edited the install script and added a exit 1 at the top
2. then had 2 xterms on pm1
a. # ma getsysteminfo -r1 // this will show that the module gets added to the configuration then remove when it fails
b. # ma addmodule ...

Comment by Daniel Lee (Inactive) [ 2017-09-14 ]

Build verified: 1.1.0-1

This test scenario no longer valid.

Now that MCOL-770 has been implemented, postConfigure will not be checking on the new node to be added. It assumes the user has the new node prepared correctly and postConfigure will not failed if the new node does not have the required software installed. In this case, startsystem will failed if the new node is misconfigured.

Close it.

Generated at Thu Feb 08 02:23:25 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.