[MCOL-669] INSERT_SELECT with TEXT column crashes Created: 2017-04-19  Updated: 2017-04-20  Resolved: 2017-04-20

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: 1.1.0
Fix Version/s: 1.1.0

Type: Bug Priority: Major
Reporter: Andrew Hutchings (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MCOL-267 TEXT and BLOB data types are not supp... Closed
Sprint: 2017-8

 Description   

Off by one on length pointer counting plus text data looping when it shouldn't



 Comments   
Comment by Andrew Hutchings (Inactive) [ 2017-04-19 ]

Pull request in develop and regression suite (test013)

Comment by Andrew Hutchings (Inactive) [ 2017-04-19 ]

Basically there were three problems:

1. cpimport's data type matching couldn't find TEXT columns, caused a bad memory read and error
2. the conversion code for INSERT...SELECT to cpimport data had a bad field length calculation for 64KB BLOB/TEXT columns
3. the conversion code for INSERT...SELECT to cpimport data was doing a bad recursive insert for TEXT data

This patch resolves all 3.

NOTE: any TEXT columns created prior to this MCOL will break once this is merged. This is due to using a bad data type ID which subsequently caused problem 1 above.

Comment by Daniel Lee (Inactive) [ 2017-04-20 ]

Build verified: Github source

[root@localhost mariadb-columnstore-server]# git show
commit 0a6aea3145f55cebffd86fdb6717284a83fbd2b7
Merge: ef372bf d9dbe2f
Author: david hill <david.hill@mariadb.com>
Date: Thu Apr 6 13:56:52 2017 -0500

Merge pull request #42 from mariadb-corporation/MCOL-377

Make audit plugin display columnstore original query in logging

[root@localhost mariadb-columnstore-server]# cd mariadb-columnstore-engine/
[root@localhost mariadb-columnstore-engine]# git show
commit f8f045f3a9792584e0b407f99c59483289e82aa1
Merge: e1a71a5 944d764
Author: dhall-InfiniDB <david.hall@mariadb.com>
Date: Thu Apr 20 14:14:50 2017 -0500

Merge pull request #155 from mariadb-corporation/MCOL-673

MCOL-673 Fix I_S/LDI for larger BLOBs

Generated at Thu Feb 08 02:22:49 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.