[MCOL-626] addModule should not be alowed on single-server installs Created: 2017-03-17  Updated: 2023-10-26  Resolved: 2017-07-14

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.0.8
Fix Version/s: 1.0.10, 1.1.0

Type: Bug Priority: Minor
Reporter: David Hill (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2017-14

 Description   

mcsadmin addModule command should error out with msg that its not allowed due to being a single-server install

mcsadmin> starts
startsystem Fri Mar 17 16:22:09 2017
startSystem command, 'columnstore' service is down, sending command to
start the 'columnstore' service on all modules

System being started, please wait.................
Successful start of System

mcsadmin> getsystemn
getsystemnetworkconfig Fri Mar 17 16:23:23 2017

System Network Configuration

Module Name Module Description NIC ID Host Name IP Address
----------- ------------------------- ------ --------- ---------------
pm1 Performance Module #1 1 localhost 127.0.0.1

mcsadmin> addmodule pm2 pm2 Calpont1
addmodule Fri Mar 17 16:23:27 2017
IP Address of pm2 not found, enter IP Address or enter 'abort'
Please enter:



 Comments   
Comment by David Hill (Inactive) [ 2017-07-07 ]

Added to check to 4 commands

mcsadmin> addmodule
addmodule Thu Jul 6 03:23:18 2017

        • addModule Failed : not support on a Single-Server type installs
          mcsadmin> removemodule
          removemodule Thu Jul 6 03:23:24 2017
        • removeModule Failed : not support on a Single-Server type installs
          mcsadmin> altersystem-en
          altersystem-enablemodule Thu Jul 6 03:23:34 2017
        • alterSystem-enableModule Failed : not support on a Single-Server type installs
          mcsadmin> altersystem-dis
          altersystem-disablemodule Thu Jul 6 03:23:37 2017
        • alterSystem-disableModule Failed : not support on a Single-Server type installs
Comment by David Hill (Inactive) [ 2017-07-07 ]

fixed in 1.0.10 and 1.1.0

develop-1.0

commit e3ba11cdbff184d4181df592efff5c7e05d99cb2
Author: david hill <david.hill@mariadb.com>
Date: Thu Jul 6 03:25:24 2017 -0500

MCOL-626

oamapps/mcsadmin/mcsadmin.cpp | 30 +++++++++++++++++++++++++++++-

develop

commit 47fb014be3ec0bbe992b67ba9741fe895001548c
Author: david hill <david.hill@mariadb.com>
Date: Thu Jul 6 03:26:45 2017 -0500

MCOL-626

oamapps/mcsadmin/mcsadmin.cpp | 34 ++++++++++++++++++++++++++++++++--

Comment by Daniel Lee (Inactive) [ 2017-07-14 ]

Builds tested: Github source for 1.0.10 and 1.1.0

1.0.10-1

[root@localhost mariadb-columnstore-server]# git show
commit 435972e50ee33911ce39696ce101d1cd23ed9c2b
Merge: b1d1ca1 5d3fcfe
Author: David.Hall <david.hall@mariadb.com>
Date: Wed Jul 12 13:07:55 2017 -0500

[root@localhost mariadb-columnstore-engine]# git show
commit 3501c1a17a920ee765c6255c5a5fd8c64fed7c8e
Author: david hill <david.hill@mariadb.com>
Date: Wed Jul 12 09:52:28 2017 -0500

1.1.0-1

[root@localhost mariadb-columnstore-server]# git show
commit 8e07495da650d922c4d1f3f09d77382168132b11
Merge: 80e57a8 c27e1e5
Author: David.Hall <david.hall@mariadb.com>
Date: Wed Jul 12 13:07:42 2017 -0500

[root@localhost mariadb-columnstore-engine]# git show
commit d1386928dcaf1d9acc92ab11e2415c808c75dd49
Author: david hill <david.hill@mariadb.com>
Date: Thu Jul 13 11:20:08 2017 -0500

Verified all 4 affected commands

Generated at Thu Feb 08 02:22:30 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.