[MCOL-566] script remote_command.sh doesn't work on SUSE Created: 2017-02-13 Updated: 2023-10-26 Resolved: 2017-09-08 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | ? |
| Affects Version/s: | 1.1.0 |
| Fix Version/s: | 1.1.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | David Hill (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
SUSE 12 |
||
| Sprint: | 2017-02 |
| Description |
|
when remote_command.sh script would has not running and it was timing out. ./remote_command.sh 172.30.0.57 'pasword' pwd 1 The issue is this line, which needs to be removed expect -re {[$#] }Its was waiting for a command line prompt of $ or #. but it wasnt seeing that, so the command would timeout... |
| Comments |
| Comment by David Hill (Inactive) [ 2017-02-13 ] |
|
1 line fix committed to develop... to test, run : ./remote_command.sh 'server' 'password' pwd 1 and make sure it returns with home directory |
| Comment by Daniel Lee (Inactive) [ 2017-02-13 ] |
|
I commented that line out and it continue to execute my script. I could see the correct results from the script on the screen, but it is returning back to the calling script. I noticed there are few more of the 'expect -rs' commands further down in the script. Do we need to modify these too? The user I am using is guest (for not root installation tests) and the system prompt ends with "~>" |
| Comment by David Hill (Inactive) [ 2017-02-13 ] |
|
good catch these should also be removed.. |
| Comment by David Hill (Inactive) [ 2017-02-13 ] |
|
addition prompting wait lines removed.. |
| Comment by Daniel Lee (Inactive) [ 2017-02-14 ] |
|
By removing the "expect -re " command, the remote-command.sh will not have an exit point, except when it times out. |
| Comment by David Hill (Inactive) [ 2017-02-14 ] |
|
Correct, we need either have it this way or code for every different type of command line prompt tasty is possible.. that is the hard part.. as we found with suse, they were different than centos. |
| Comment by David Hill (Inactive) [ 2017-02-14 ] |
|
With the current way, it will always work but will be slower waiting for the timeout. |
| Comment by David Hill (Inactive) [ 2017-02-14 ] |
|
in develop branch... I added back in the checking for command line prompts as a end of command, so its faster and not waiting on timeouts This is how you would use if the command line prompt was set to 'david' ./remote_command.sh 127.0.0.1 Calpont1 pwd 1 david So this now works on SuSE and has the option for other custom command line prompts |
| Comment by David Thompson (Inactive) [ 2017-06-05 ] |
|
Can you surface that as an optional argument in postCfg as it would lets us support the user overriding this? |
| Comment by David Hill (Inactive) [ 2017-06-06 ] |
|
Fixed with a changed associated to |
| Comment by Daniel Lee (Inactive) [ 2017-09-08 ] |
|
Build verified: 1.1.0-1 linux-p7qp:/usr/local/mariadb/columnstore/bin # time ./remote_command.sh s2um1 vagrant pwd 1 real 0m0.410s |