[MCOL-548] clean up engine repo cmake warnings Created: 2017-02-07 Updated: 2018-02-13 Resolved: 2018-02-13 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 1.2.0 |
| Type: | New Feature | Priority: | Trivial |
| Reporter: | David Hill (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 2018-03, 2018-04 |
| Description |
|
These errors get reported on Ubuntu and SuSE builds when the engine cmake is run Cloning into 'mariadb-columnstore-engine'... The dependency target CMake Warning (dev) at dbcon/ddlpackage/CMakeLists.txt:35 (add_dependencies): The dependency target CMake Warning (dev) at dbcon/dmlpackage/CMakeLists.txt:35 (add_dependencies): The dependency target CMake Warning (dev) at dbcon/dmlpackage/CMakeLists.txt:35 (add_dependencies): The dependency target |
| Comments |
| Comment by Andrew Hutchings (Inactive) [ 2017-02-07 ] |
|
They happen due to our builds requiring cpp files that don't exist yet. They don't exist because boost hasn't been run yet. We should be able to suppress them. |
| Comment by Roman [ 2018-01-24 ] |
|
Cmake generates the warnings when it doesn't find cpp files generated by flex and bison at the configuration step since ADD_CUSTOM_COMMAND used for both files run later in the build step. I added custom targets that depend on generated files to get over with the warnings so please take a look at it. |
| Comment by Daniel Lee (Inactive) [ 2018-02-12 ] |
|
Build tested: Github source for 1.2.0-1 root@vagrant:~/columnstore# cd mariadb-columnstore-server/ Update README.md diff --git a/README.md b/README.md ```bash
root@vagrant:~/columnstore/mariadb-columnstore-server# cd mariadb-columnstore-engine/ Merge branch 'master' into develop-1.1 root@vagrant:~/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine# Should the following build warnings be suppressed? root@vagrant:~# cat buildMCS.log |grep -i "cmake warning" |
| Comment by Daniel Lee (Inactive) [ 2018-02-13 ] |
|
Build verified: Github source 1.2.0-1 /root/columnstore/mariadb-columnstore-server Update README.md diff --git a/README.md b/README.md ```bash
/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #399 from drrtuy/ Built project using Ubuntu 16.04 and verified cmake output |