[MCOL-547] enforce limitation of postCfg needing to be run on pm1 Created: 2017-02-07 Updated: 2018-08-31 Resolved: 2017-03-22 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | installation |
| Affects Version/s: | 1.0.6 |
| Fix Version/s: | 1.0.8, 1.1.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | David Thompson (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sub-Tasks: |
|
||||||||||
| Sprint: | 2017-5, 2017-6 |
| Description |
|
postConfigure is documented as requireing that you run and configure this for what becomes the pm1 server. However it doesn't enforce this and if you end up performing a multi node seperate install and enter values such that the current server ends up being a um server then the install fails badly. We should either remove the limitation or if this is too tricky, enforce or validate the current server is pm1. |
| Comments |
| Comment by David Hill (Inactive) [ 2017-02-28 ] |
|
So this change will only apply if an upgrade is being done... We can check to see if the module is pm1 and if so, perform the postConfigure run. But if its a new system, then the local node will not assign or is assigned as the default of pm1. |
| Comment by David Hill (Inactive) [ 2017-03-01 ] |
|
Added code to compare the configure pm1 ip address versus the IP address of the local server where the command is running. Here is the new Error exit when it is run on a non-pm1 node. Do you want to utilize the configuration data from the saved copy? [y,n] > y ERROR: postConfigure install can only be done on the PM1 |
| Comment by David Hill (Inactive) [ 2017-03-01 ] |
|
please rewiew pull request code change, added code to get local ip and compare with the PM1 configured IP address. Only allow postConfigure to run on preinstalled systems on pm1 node |
| Comment by David Hill (Inactive) [ 2017-03-09 ] |
|
additional changes needed based in review input |
| Comment by Ben Thompson (Inactive) [ 2017-03-09 ] |
|
Reviewed and Merged. |
| Comment by Daniel Lee (Inactive) [ 2017-03-21 ] |
|
Build verified: 1.0.8-1 ERROR: postConfigure install can only be done on the PM1 Still need to test for 1.1.0 |
| Comment by Daniel Lee (Inactive) [ 2017-03-22 ] |
|
Build verified: 1.1.0 Github source [root@localhost mariadb-columnstore-server]# git show [root@localhost mariadb-columnstore-server]# cd mariadb-columnstore-engine/ |