[MCOL-5449] fails to build against MariaDB communIty -11.0 handler::scan_time() changed Created: 2023-03-10  Updated: 2024-01-25  Resolved: 2023-03-10

Status: Closed
Project: MariaDB ColumnStore
Component/s: MariaDB Server
Affects Version/s: None
Fix Version/s: 6.4.8-CS only

Type: Bug Priority: Blocker
Reporter: Daniel Black Assignee: Roman
Resolution: Fixed Votes: 0
Labels: None


 Description   

build logs: https://buildbot.mariadb.org/#/builders/358/builds/5135/steps/5/logs/stdio

server branch bb-11.0-serg (where submodule bump to fix MCOL-5437 was included)

In file included from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/storage/columnstore/columnstore/dbcon/mysql/ha_mcs_impl.h:59,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/storage/columnstore/columnstore/dbcon/mysql/ha_mcs_client_udfs.cpp:21:
/home/buildbot/amd64-ubuntu-2204-deb-autobake/build/storage/columnstore/columnstore/dbcon/mysql/ha_mcs.h:124:18: error: conflicting return type specified for ‘virtual double ha_mcs::scan_time()’
  124 |   virtual double scan_time() override
      |                  ^~~~~~~~~
In file included from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/sql/log.h:20,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/sql/sql_class.h:28,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/sql/procedure.h:31,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/sql/sql_select.h:31,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/storage/columnstore/columnstore/dbcon/mysql/idb_mysql.h:76,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/storage/columnstore/columnstore/dbcon/mysql/ha_mcs_impl.h:22,
                 from /home/buildbot/amd64-ubuntu-2204-deb-autobake/build/storage/columnstore/columnstore/dbcon/mysql/ha_mcs_client_udfs.cpp:21:
/home/buildbot/amd64-ubuntu-2204-deb-autobake/build/sql/handler.h:3641:27: note: overridden function is ‘virtual IO_AND_CPU_COST handler::scan_time()’
 3641 |   virtual IO_AND_CPU_COST scan_time()
      |                           ^~~~~~~~~
make[4]: *** [storage/columnstore/columnstore/dbcon/mysql/CMakeFiles/columnstore.dir/build.make:107: storage/columnstore/columnstore/dbcon/mysql/CMakeFiles/columnstore.dir/ha_mcs_client_udfs.cpp.o] Error 1
make[3]: *** [CMakeFiles/Makefile2:6586: storage/columnstore/columnstore/dbcon/mysql/CMakeFiles/columnstore.dir/all] Error 2
make[3]: *** Waiting for unfinished jobs....

Server commit [b66cdbd1eaee changed the definition to be virtual IO_AND_CPU_COST scan_time()

Like MCOL-5437 condition code needed.



 Comments   
Comment by Roman [ 2023-03-10 ]

The relevant commit has been pushed into develop-6.

Generated at Thu Feb 08 02:57:58 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.