[#MCOL-5428] The conversion from strings to values and vice versa should use NullString

[MCOL-5428] The conversion from strings to values and vice versa should use NullString Created: 2023-02-20 Updated: 2023-07-01
Status:	Open
Project:	MariaDB ColumnStore
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Icebox

Type:

Task

Priority:

Major

Reporter:

Sergey Zefirov

Assignee:

Unassigned

Resolution:

Unresolved

Votes:

Labels:

None

Description

There is an example from mcs_datatypes.h:

 // hasTSInt128 explicitly tells to print int128 out in cases

  // where precision can't detect decimal type properly, e.g.

  // DECIMAL(10)/DECIMAL(38)

  std::string toString(bool hasTSInt128 = false) const;

  utils::NullString toNullString(bool hasTSInt128 = false) const;

Note that there are toString and toNullString but their essence is the same.

Ideally, we should convert the NULL values too and having NullString as a result (or input) is the right way to do that.

Generated at Thu Feb 08 02:57:48 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.