[MCOL-5400] Disable GROUP BY Pushdown by default Created: 2023-01-26  Updated: 2023-02-14  Resolved: 2023-02-09

Status: Closed
Project: MariaDB ColumnStore
Component/s: MDB Plugin
Affects Version/s: 22.08.7
Fix Version/s: 23.02.1

Type: Task Priority: Major
Reporter: Roman Assignee: Roman
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2022-23
Assigned for Review: Leonid Fedorov Leonid Fedorov
Assigned for Testing: Daniel Lee Daniel Lee (Inactive)

 Description   

The mentioned GROUP BY pushdown proved to be error-prone, e.g. its execution starts after optimize phase so MDB optimizer might has rewritten JOIN conditions dropping some of them. The optimized conditions forces the query to error-out. Moreover this pushdown method are rarely called b/c it is the last in the precedence of pushdown methods available:

  • select handler
  • derived handler
  • group by handler
  • table scan with conditions
    Deactivation of GBH might implicitly affects the variety of queries that MCS can process so at least full test001 should be run with the patch.


 Comments   
Comment by Roman [ 2023-01-27 ]

4QA regression tests must pass.

Comment by Daniel Lee (Inactive) [ 2023-02-09 ]

Build verified: latest build for the develop branch

engine: b2206521cea8c15c0bf6e8d217a08783c483a963
server: 2b721f6864d135aa9a1916798e8daf29e213211e
buildNo: 6716

Execute all MTR test suites. All but few cases with known issues passed.

Test result is the same as 22.08.8.

Generated at Thu Feb 08 02:57:36 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.