[MCOL-5361] prepare/execute : accomodate latest changes in server 10.6.11 Created: 2022-12-16  Updated: 2022-12-27  Resolved: 2022-12-21

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: None
Fix Version/s: 22.08.7

Type: Task Priority: Blocker
Reporter: alexey vorovich (Inactive) Assignee: Roman
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-29988 Major performance regression with 10.... Closed
Sprint: 2022-22
Assigned for Review: Gagan Goel Gagan Goel (Inactive)
Assigned for Testing: Daniel Lee Daniel Lee (Inactive)

 Comments   
Comment by alexey vorovich (Inactive) [ 2022-12-16 ]

https://mariadb.slack.com/archives/C046YH1GVRT/p1671114896644769

Comment by David Hall (Inactive) [ 2022-12-19 ]

In drone, test001 failed. Investigation shows that test working_tpch1_compareLogOnly/sub/sub.select.04 fails on all platforms with and without the MDEV_29988 patch
To verify, I ran the test locally with the MDEV_29988 patch in server:
Before patch from working_tpch1_compareLogOnly/sub/sub.select.04.sql using this sequence:

  • run query
  • cherry-pick patch
  • run query

Before Patch:

select r_name, 
     (select count(*) 
     from supplier
 
     where s_nationkey = n_nationkey) suppcount,
 
    (select count(*) 
     from customer
 
     where c_nationkey = n_nationkey) custcount
 
    from region
 
    join nation on r_regionkey = n_regionkey
 
    group by 1, 2, 3
 
    order by 1, 2, 3;
 
 
 
+-------------+-----------+-----------+
 
| r_name      | suppcount | custcount |
 
+-------------+-----------+-----------+
 
| AFRICA      |       373 |      5921 |
 
| AFRICA      |       376 |      5992 |
 
| AFRICA      |       380 |      5952 |
 
| AFRICA      |       406 |      5974 |
 
| AFRICA      |       420 |      5925 |
 
| AMERICA     |       393 |      5983 |
 
| AMERICA     |       397 |      5999 |
 
| AMERICA     |       412 |      6020 |
 
| AMERICA     |       413 |      5975 |
 
| AMERICA     |       421 |      5975 |
 
| ASIA        |       377 |      5948 |
 
| ASIA        |       399 |      6008 |
 
| ASIA        |       405 |      6161 |
 
| ASIA        |       407 |      6024 |
 
| ASIA        |       415 |      6042 |
 
| EUROPE      |       390 |      6011 |
 
| EUROPE      |       396 |      5908 |
 
| EUROPE      |       398 |      6100 |
 
| EUROPE      |       401 |      6078 |
 
| EUROPE      |       402 |      6100 |
 
| MIDDLE EAST |       362 |      6033 |
 
| MIDDLE EAST |       393 |      6009 |
 
| MIDDLE EAST |       411 |      5904 |
 
| MIDDLE EAST |       415 |      5995 |
 
| MIDDLE EAST |       438 |      5963 |
 
+-------------+-----------+-----------+
 
25 rows in set (0.303 sec)
 
4:19

After r patch

select r_name, 
     (select count(*) 
     from supplier
 
     where s_nationkey = n_nationkey) suppcount,
 
    (select count(*) 
     from customer
 
     where c_nationkey = n_nationkey) custcount
 
    from region
 
    join nation on r_regionkey = n_regionkey
 
    group by 1, 2, 3
 
    order by 1, 2, 3;
 
 
 
ERROR 1815 (HY000): Internal error: MCS-1000: 'supplier' and 'nation' are not joined.

Comment by Daniel Lee (Inactive) [ 2022-12-21 ]

Build tested:

MCS 22.08.7 RC2 bb-10.6.11-5-cs-22.08.7-1/27466a7e3a7183de364ed1bb426f3dc941849938
CMAPI 22.08.2, build 823

Related MTR test cases passed.

Generated at Thu Feb 08 02:57:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.