[MCOL-5276] Build failures if LZ4 not enabled Created: 2022-10-25  Updated: 2023-01-26  Resolved: 2023-01-26

Status: Closed
Project: MariaDB ColumnStore
Component/s: MDB Plugin
Affects Version/s: None
Fix Version/s: 6.4.6

Type: Bug Priority: Major
Reporter: Andrew Hutchings Assignee: Roman
Resolution: Fixed Votes: 0
Labels: None


 Description   

When compiling MariaDB 10.11 with ColumnStore, in ha_mcs_sysvar.cpp:

static MYSQL_THDVAR_ENUM(compression_type, PLUGIN_VAR_RQCMDARG,
 
                          "SNAPPY segment files are Snappy compressed (default);"
 
 #ifdef HAVE_LZ4
 
                          "LZ4 segment files are LZ4 compressed;",
 
 #endif

That final comma is missing if HAVE_LZ4 is not defined, causing build failure. Recommend adding to following or moving the comma outside of the gate.

#else
 
,



 Comments   
Comment by Roman [ 2023-01-26 ]

Thx for the heads up.
I had fixed this some time ago. Here is the ref for the next CS release. However the prev engine ref had this macros issue fixed also.

Generated at Thu Feb 08 02:56:40 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.