[MCOL-483] Error in shell script Created: 2016-12-23 Updated: 2017-01-17 Resolved: 2017-01-16 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | installation |
| Affects Version/s: | 1.0.6.1 |
| Fix Version/s: | 1.0.7 |
| Type: | Bug | Priority: | Major |
| Reporter: | Allan | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Environment: |
Centos 6 |
||
| Sprint: | 2017-01 |
| Description |
|
In line 61 of /etc/init.d/columnstore $USER should be "$USER" or the script reports an error |
| Comments |
| Comment by David Hill (Inactive) [ 2017-01-09 ] |
|
did a pull request |
| Comment by Ben Thompson (Inactive) [ 2017-01-11 ] |
|
Reviewed and merged |
| Comment by David Hill (Inactive) [ 2017-01-16 ] |
|
there wasn't a failure reported before on this, just a user reported it as being incorrect. just make sure the columnstore starts up after an install and after a shutdown and startsystem. This is where the script is run |
| Comment by Allan [ 2017-01-16 ] |
|
I reported this because the script reported an error and started up differently. The issue is that if $USER does not evaluate to anything the test is incorrect. The double quotes make sure in this case that there is something there even if it is empty, and yes in our system in this case it evaluates to nothing. I'm assuming the line will be fixed and possibly others with the same issue rather than just checking that the server started. |
| Comment by Daniel Lee (Inactive) [ 2017-01-16 ] |
|
Build verified: Github source [root@localhost mariadb-columnstore-server]# git show Merge pull request #26 from mariadb-corporation/ Update README.md 61 if [ "$USER" != "root" ]; then |