[MCOL-4814] Enable CS build with LZ4 compression only by build flag Created: 2021-07-15  Updated: 2021-07-23  Resolved: 2021-07-23

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1.1

Type: Task Priority: Blocker
Reporter: Denis Khalikov Assignee: David Hall (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2021-9

 Comments   
Comment by Sergei Golubchik [ 2021-07-15 ]

Ideally, it should be something like

SET(WITH_COLUMNSTORE_LZ4 AUTO CACHE STRING
  "Build with lz4. Possible values are 'ON', 'OFF', 'AUTO' and default is 'AUTO'")

and with OFF it won't link with lz4, with ON it'll fail if lz4 is not found (like now). WIth AUTO it'll build with lz4 if it's found, otherwise without.

Doing it without any option at all, just always auto, is fine too.

Comment by Denis Khalikov [ 2021-07-15 ]

Updated, based on comments.
https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/2051

Comment by Denis Khalikov [ 2021-07-16 ]

dleeyh Since we have a policy to test every PR, I moved it to you, I think it's ok to just test that CS has LZ4 support after this patch, since all our build systems have lz4 installed and we running under "AUTO" option.

Generated at Thu Feb 08 02:53:12 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.