The problem is not in the join, as I first suspected, but rather in the IN. The following query returns 0 when run in table mode (infinidb_vtable_mode=0):

SELECT COUNT(*) FROM PART WHERE P_CONTAINER IN ('SM CASE', 'SM BOX', 'SM PACK', 'SM PKG');

In vtable mode (infinidb_vtable_mode=2), the answer is correct: 19906

So use this query rather than the complicated one to chase the error.

When the IN is reduced to one item in the list, it works:

SELECT COUNT(*) FROM PART WHERE P_CONTAINER IN ('SM CASE');

The issue is that String::copy() doesn't put the NULL terminator on the copied string. I know this sounds wierd, but bear with me.

When the strings of the IN are processed, they're placed into an in_string object, defined in item_cmpfunc. This class maintains it's own buffer, but the objects in the buffer are String objects. The buffers to the string objects are pointers to the original string in the item. That is, it's not a deep copy.

in Item_func_in::fix_length_and_dec, a copy of the original string is made. When it is, the null is not terminator is not set. It is this pointer that is placed in the in_string object.

In InfiniDB processing, we need to get a copy of these strings to set up our own filter. We use the function c_ptr() to access them. c-ptr() reallocates because Ptr[str_length] is not 0 – there's no terminator. This reallocation messes up the in_string object. Plus, with all the garbage in the strings, InfiniDB's compare fails. There's a double failure.

Anyway, to fix in Columnstore, we no longer use c_ptr, but rather ptr. It also trims to str->length() before using.

For QA

dleeyhHas this been verified ?

Build tested:

getsoftwareinfo Tue May 31 10:30:28 2016

Name : mariadb-columnstore-platform Relocations: (not relocatable)
Version : 1.0 Vendor: MariaDB Corporation Ab
Release : 0 Build Date: Fri 27 May 2016 04:07:53 PM EDT
Install Date: Mon 30 May 2016 11:32:15 AM EDT Build Host: srvbuilder

For vtable mode 0, it worked. For vtable mode 1, it still returned a syntax error.

MariaDB [mytest]> SELECT SUM(L_EXTENDEDPRICE * (1 - L_DISCOUNT)) AS REVENUE FROM LINEITEM, PART WHERE ( P_PARTKEY = L_PARTKEY AND P_BRAND = 'Brand#41' AND P_CONTAINER IN ( 'SM CASE', 'SM BOX', 'SM PACK', 'SM PKG') AND L_QUANTITY >= 3 AND L_QUANTITY <= 3 + 1 AND P_SIZE BETWEEN 1 AND 5 AND L_SHIPMODE IN ('AIR', 'AIR REG') AND L_SHIPINSTRUCT = 'DELIVER IN PERSON' ) OR ( P_PARTKEY = L_PARTKEY AND P_BRAND = 'Brand#33' AND P_CONTAINER IN ( 'MED BAG', 'MED BOX', 'MED PKG', 'MED PACK') AND L_QUANTITY >= 14 AND L_QUANTITY <= 14 + 1 AND P_SIZE BETWEEN 1 AND 10 AND L_SHIPMODE IN ('AIR', 'AIR REG') AND L_SHIPINSTRUCT = 'DELIVER IN PERSON' ) OR ( P_PARTKEY = L_PARTKEY AND P_BRAND = 'Brand#45' AND P_CONTAINER IN ( 'LG CASE', 'LG BOX', 'LG PACK', 'LG PKG') AND L_QUANTITY >= 25 AND L_QUANTITY <= 25 + 1 AND P_SIZE BETWEEN 1 AND 15 AND L_SHIPMODE IN ('AIR', 'AIR REG') AND L_SHIPINSTRUCT = 'DELIVER IN PERSON' );
ERROR 1815 (HY000): Internal error: IDB-1000: 'lineitem' and 'part' are not joined.
MariaDB [mytest]> show variables like "%vtable%";
---------------------------+

---------------------------+

---------------------------+
1 row in set (0.00 sec)

MariaDB [mytest]> set infinidb_vtable_mode=0;
Query OK, 0 rows affected (0.00 sec)

MariaDB [mytest]> SELECT SUM(L_EXTENDEDPRICE * (1 - L_DISCOUNT)) AS REVENUE FROM LINEITEM, PART WHERE ( P_PARTKEY = L_PARTKEY AND P_BRAND = 'Brand#41' AND P_CONTAINER IN ( 'SM CASE', 'SM BOX', 'SM PACK', 'SM PKG') AND L_QUANTITY >= 3 AND L_QUANTITY <= 3 + 1 AND P_SIZE BETWEEN 1 AND 5 AND L_SHIPMODE IN ('AIR', 'AIR REG') AND L_SHIPINSTRUCT = 'DELIVER IN PERSON' ) OR ( P_PARTKEY = L_PARTKEY AND P_BRAND = 'Brand#33' AND P_CONTAINER IN ( 'MED BAG', 'MED BOX', 'MED PKG', 'MED PACK') AND L_QUANTITY >= 14 AND L_QUANTITY <= 14 + 1 AND P_SIZE BETWEEN 1 AND 10 AND L_SHIPMODE IN ('AIR', 'AIR REG') AND L_SHIPINSTRUCT = 'DELIVER IN PERSON' ) OR ( P_PARTKEY = L_PARTKEY AND P_BRAND = 'Brand#45' AND P_CONTAINER IN ( 'LG CASE', 'LG BOX', 'LG PACK', 'LG PKG') AND L_QUANTITY >= 25 AND L_QUANTITY <= 25 + 1 AND P_SIZE BETWEEN 1 AND 15 AND L_SHIPMODE IN ('AIR', 'AIR REG') AND L_SHIPINSTRUCT = 'DELIVER IN PERSON' );
-------------

-------------

-------------
1 row in set (15.02 sec)

The syntax error issue has been moved to ticket MCOL-91 so I am closing this ticket.