[MCOL-453] change mcsadmin to only allow the module add/remove/disable commands from active PM Module Created: 2016-12-08  Updated: 2023-10-26  Resolved: 2017-01-20

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.0.5
Fix Version/s: 1.0.7

Type: New Feature Priority: Minor
Reporter: David Hill (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2016-24, 2016-25, 2017-01, 2017-2

 Description   

Change the following commands to only allow them to be run from the Active OAM Parent PM module, which generally is PM1. All change and update type commands should only be run from this module.

Commands changed:

addModule
removeModule
alterSystem-disableModule
alterSystem-enableModule

 Comments   
Comment by David Hill (Inactive) [ 2016-12-08 ]

Changed mcsadmin to remove/add/alterSystem commands to only allow to run on active oam parent

commit 10b0199e81eb8e445abd240f1a6b45e32f02df6e
Author: David Hill <david.hill@mariadb.com>
Date: Thu Dec 8 13:15:55 2016 -0600

MCOL-452

oam/install_scripts/performance_installer.sh | 4 ++--
oam/install_scripts/user_installer.sh | 4 ++--
oamapps/mcsadmin/mcsadmin.cpp | 13 -------------
3 files changed, 4 insertions, 17 deletions

Comment by David Hill (Inactive) [ 2016-12-08 ]

please review

Comment by Ben Thompson (Inactive) [ 2016-12-08 ]

Reviewed, looks good to me

Comment by Daniel Lee (Inactive) [ 2016-12-12 ]

Build tested: 1.0.6-1

getsoftwareinfo Mon Dec 12 17:50:23 2016

Name : mariadb-columnstore-platform
Version : 1.0.6
Release : 1
Architecture: x86_64
Install Date: Mon 12 Dec 2016 05:30:41 PM UTC
Group : Applications/Databases
Size : 10016657
License : Copyright (c) 2016 MariaDB Corporation Ab., all rights reserved; redistributable under the terms of the GPL, see the file COPYING for details.
Signature : (none)
Source RPM : mariadb-columnstore-platform-1.0.6-1.src.rpm
Build Date : Fri 09 Dec 2016 11:25:12 PM UTC

The removeModule command still can be executed from UM1 and PM2, which are non-active PM module.

Comment by David Hill (Inactive) [ 2016-12-14 ]

Previously checked in one fix for removeModule.. Then checked in other to correct a cutand paste issue. change comment of addModule to removeModule.

commit d260bb4bfb64d55f481d070c8a5c8ed81e3cd3c9
Author: David Hill <david.hill@mariadb.com>
Date: Wed Dec 14 13:47:39 2016 -0600

MCOL-453

oamapps/mcsadmin/mcsadmin.cpp | 4 ++--
1 file changed, 2 insertions, 2 deletions

commit fae09df1b7c5b62092189eec7747169e4708464b
Author: David Hill <david.hill@mariadb.com>
Date: Mon Dec 12 11:59:51 2016 -0600

MCOL-453 - added check to not allow removemodule to run on non-parent

Comment by David Hill (Inactive) [ 2016-12-14 ]

I originally didnt have this check for removeModule, so it has been added, please check and review

Comment by Ben Thompson (Inactive) [ 2016-12-15 ]

Reviewed, looks good.

Comment by David Hill (Inactive) [ 2017-01-11 ]

to be reviewed

Comment by Ben Thompson (Inactive) [ 2017-01-11 ]

Reviewed and merged

Comment by Daniel Lee (Inactive) [ 2017-01-20 ]

Build verified: 1.0.7-1

mcsadmin> getsoft
getsoftwareinfo Fri Jan 20 23:05:47 2017

Name : mariadb-columnstore-platform
Version : 1.0.7
Release : 1
Architecture: x86_64
Install Date: Fri 20 Jan 2017 10:46:14 PM UTC
Group : Applications/Databases
Size : 10001348
License : Copyright (c) 2016 MariaDB Corporation Ab., all rights reserved; redistributable under the terms of the GPL, see the file COPYING for details.
Signature : (none)
Source RPM : mariadb-columnstore-platform-1.0.7-1.src.rpm

Verified removeModule check has been added.

Generated at Thu Feb 08 02:21:11 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.