Full DECIMAL support in ColumnStore (MCOL-641)

[MCOL-4390] Overflow checks fails in decimal unit tests Created: 2020-11-13  Updated: 2020-11-23  Resolved: 2020-11-23

Status: Closed
Project: MariaDB ColumnStore
Component/s: ExeMgr
Affects Version/s: None
Fix Version/s: 5.4.1

Type: Sub-Task Priority: Major
Reporter: Roman Assignee: Roman
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2020-1, 2020-2, 2020-3, 2020-4, 2020-5, 2020-6, 2020-7, 2021-1, 2021-2, 2021-3, 2021-4, 2021-5, 2021-6, 2021-7, 2021-8, 2021-9

 Description   

root@drrtuy-devel-1:/data/mdb-server/storage/columnstore/columnstore# ./bin/mcs_decimal_tests 
Running main() from gtest_main.cc
[==========] Running 13 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 13 tests from Decimal
[ RUN      ] Decimal.compareCheck
[       OK ] Decimal.compareCheck (0 ms)
[ RUN      ] Decimal.additionNoOverflowCheck
[       OK ] Decimal.additionNoOverflowCheck (0 ms)
[ RUN      ] Decimal.divisionNoOverflowCheck
[       OK ] Decimal.divisionNoOverflowCheck (0 ms)
[ RUN      ] Decimal.divisionWithOverflowCheck
[       OK ] Decimal.divisionWithOverflowCheck (0 ms)
[ RUN      ] Decimal.additionWithOverflowCheck
/data/mdb-server/storage/columnstore/columnstore/tests/mcs_decimal-tests.cpp:512: Failure
Expected: doAdd(l, r, result) throws an exception of type logging::OperationOverflowExcept.
  Actual: it throws nothing.
[  FAILED  ] Decimal.additionWithOverflowCheck (0 ms)
[ RUN      ] Decimal.subtractionNoOverflowCheck
[       OK ] Decimal.subtractionNoOverflowCheck (0 ms)
[ RUN      ] Decimal.subtractionWithOverflowCheck
/data/mdb-server/storage/columnstore/columnstore/tests/mcs_decimal-tests.cpp:687: Failure
Expected: doSubtract(l, r, result) throws an exception of type logging::OperationOverflowExcept.
  Actual: it throws nothing.
[  FAILED  ] Decimal.subtractionWithOverflowCheck (0 ms)
[ RUN      ] Decimal.multiplicationNoOverflowCheck
[       OK ] Decimal.multiplicationNoOverflowCheck (0 ms)
[ RUN      ] Decimal.multiplicationWithOverflowCheck
/data/mdb-server/storage/columnstore/columnstore/tests/mcs_decimal-tests.cpp:853: Failure
Expected: doMultiply(l, r, result) throws an exception of type logging::OperationOverflowExcept.
  Actual: it throws nothing.
/data/mdb-server/storage/columnstore/columnstore/tests/mcs_decimal-tests.cpp:869: Failure
Expected: doMultiply(l, r, result) throws an exception of type logging::OperationOverflowExcept.
  Actual: it throws nothing.
[  FAILED  ] Decimal.multiplicationWithOverflowCheck (0 ms)
[ RUN      ] Decimal.DecimalToStringCheckScale0
[       OK ] Decimal.DecimalToStringCheckScale0 (0 ms)
[ RUN      ] Decimal.DecimalToStringCheckScale10
[       OK ] Decimal.DecimalToStringCheckScale10 (0 ms)
[ RUN      ] Decimal.DecimalToStringCheckScale38
[       OK ] Decimal.DecimalToStringCheckScale38 (0 ms)
[ RUN      ] Decimal.DecimalToStringCheckScale37
[       OK ] Decimal.DecimalToStringCheckScale37 (0 ms)
[----------] 13 tests from Decimal (0 ms total)
 
[----------] Global test environment tear-down
[==========] 13 tests from 1 test case ran. (1 ms total)
[  PASSED  ] 10 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] Decimal.additionWithOverflowCheck
[  FAILED  ] Decimal.subtractionWithOverflowCheck
[  FAILED  ] Decimal.multiplicationWithOverflowCheck
 
 3 FAILED TESTS


Generated at Thu Feb 08 02:49:59 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.