[MCOL-42] xor has changed and no longer works Created: 2016-05-06 Updated: 2016-06-02 Due: 2016-05-09 Resolved: 2016-06-02 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | ExeMgr |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | David Hall (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Centos 6.5 |
||
| Sprint: | MCOL Sprint 2 - Priority 2 |
| Description |
|
Mysql 5.1 sent xor as an Item_cond_xor structure. MariaDB 10.1 sends an Item_func_xor structure which has to be handled differently. |
| Comments |
| Comment by Dipti Joshi (Inactive) [ 2016-05-23 ] |
|
wlad What was your analysis/finding on this ? I see you put it in review and assigned to David Hall. Need to understand if this has been fixed now. |
| Comment by Vladislav Vaintroub [ 2016-05-23 ] |
|
dshjoshi It is assigned to David. David needs to close this. But I pushed to the repo I was in ( I think this is david hills, I have no idea about the correct location of the master) This has some implication, e.g the Item type is different and parameters are in different locatiomn. I changed the code so Xor can be handled just like before, together with logical ops, also had to do required fixes to marshal its params which are in an array now, into a list, like for other logical ops. |
| Comment by Vladislav Vaintroub [ 2016-05-23 ] |
|
For the reference, which bug fix caused changes in XOR , it is https://jira.mariadb.org/browse/MDEV-8167 |
| Comment by Dipti Joshi (Inactive) [ 2016-05-25 ] |
|
David.Hall - Please give example of xor not working before and what should be the expected result - so that Daniel Lee can verify that it works now. Also the bug fix that wlad did - is it already in our code master branch now ? |
| Comment by Daniel Lee (Inactive) [ 2016-06-02 ] |
|
Build verified: mscadmin> getsoft Name : mariadb-columnstore-platform Relocations: (not relocatable) Verified by autopilot test cases |