[MCOL-4155] Reduce redundancy & confusion around having two columnstore.cnf files Created: 2020-07-08 Updated: 2020-11-09 Resolved: 2020-11-09 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | N/A |
| Affects Version/s: | None |
| Fix Version/s: | 5.5.1 |
| Type: | Task | Priority: | Minor |
| Reporter: | Patrick LeBlanc (Inactive) | Assignee: | Ben Thompson (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||
| Sprint: | 2020-8 | ||||
| Description |
|
Serg correctly observed that after merging one of his PRs into develop, we are now deploying both a x-columnstore.cnf and a columnstore.cnf file in both community and enterprise, b/c we don't have a separate branch or repo for each. For community, the x-columnstore.cnf is unnecessary, and once we're gamma-level, the plugin-maturity option can be removed (b/c gamma is the default there). His suggestion to avoid having both is to package only columnstore.cnf, and have post-install generate x-columnstore.cnf IF it sees the enterprise-specific .cnf file in /etc/my.cnf.d Other option is to mod cmake to detect the INSTALL_LAYOUT var, and if enterprise, install x-columnstore.cnf. Else, don't. Multiple easy options. It should be done before the next release. |
| Comments |
| Comment by David Hall (Inactive) [ 2020-08-18 ] |
|
The enterprise build should have a x-columnstore.cnf (not sure about the hyphen). Community build should have columnstore.cnf. Neither should have both. Note that the name change is made during installation of packages. |
| Comment by Ben Thompson (Inactive) [ 2020-08-19 ] |
|
Fix needs to be redone to work with building columnstore as submodule of server |
| Comment by David Hall (Inactive) [ 2020-09-14 ] |
|
We need the Jenkins build from Server to test. |