[MCOL-4124] DMLProc does not return error when command (commit, rollback) fails. Created: 2020-06-29 Updated: 2020-11-12 Resolved: 2020-07-30 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | MDB Plugin |
| Affects Version/s: | 1.5.2 |
| Fix Version/s: | 5.4.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | David Hall (Inactive) | Assignee: | David Hall (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 2020-7, 2020-8 |
| Description |
|
In the rare case that a dml command fails, such as COMMIT and ROLLBack, the error is set, but an OK is returned. Server gets confused and Asserts. All calls to ProcessCommandStatement() in ha_mcs_dml.cpp should set rc to the return code from the function. |
| Comments |
| Comment by Gregory Dorman (Inactive) [ 2020-07-07 ] |
|
Cannot be tested (no reproduction). If review succeeds, close post regression / autopilot. |
| Comment by Gagan Goel (Inactive) [ 2020-07-08 ] |
|
I found a couple issues with the PR that was merged for this ticket. Comments are in https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/1316 Also David.Hall, looking at this file, I am also seeing inconsistencies in the usage of ci.rc. At some places we set it to rc when rc != 0, while at other places we don't. I think we need to consolidate this. |
| Comment by Gagan Goel (Inactive) [ 2020-07-08 ] |
|
Also, I think the fix should also go into 1.4 and 1.2. Reassigning to David. |
| Comment by Daniel Lee (Inactive) [ 2020-07-10 ] |
|
Build tested: 1.5.3-1 9 (drone #280) Autopilot test passed. |