[MCOL-4067] ColumnStore build has way too many build warnings Created: 2020-06-16  Updated: 2020-07-07  Resolved: 2020-06-24

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Otto Kekäläinen Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None

Issue Links:
Blocks
blocks MCOL-4057 Package ColumnStore 5.x with 10.5 ser... Closed
Duplicate
is duplicated by MCOL-4030 Look into and fix or suppress the 13k... Closed

 Description   

It seems the ColumnStore build has so many warnings that building it completely floods the build log.

Can these be fixed? They are after all defects that automatic tools found.
Or how should I build to silence these warnings?

/builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/operator.h:218:26: warning: implicitly-declared 'execplan::CalpontSystemCatalog::ColType& execplan::CalpontSystemCatalog::ColType::operator=(const execplan::CalpontSystemCatalog::ColType&)' is deprecated [-Wdeprecated-copy]
   218 |         fOperationType = ot;
       |                          ^~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/treenode.h:35,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/parsetree.h:31,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:32,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:26,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_repeat.cpp:29:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:303:9: note: because 'execplan::CalpontSystemCatalog::ColType' has user-provided 'execplan::CalpontSystemCatalog::ColType::ColType(const execplan::CalpontSystemCatalog::ColType&)'
   303 |         ColType(const ColType& rhs);
       |         ^~~~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:26,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_repeat.cpp:29:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h: At global scope:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:173:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   173 |     const float floatNullVal() const
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:177:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   177 |     const double doubleNullVal() const
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:181:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   181 |     const long double longDoubleNullVal() const
       |     ^~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_repeat.cpp:29:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:119:2: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   119 |  const void stringValue(execplan::SPTP& fp, rowgroup::Row& row, bool& isNull, std::string& fFloatStr)
       |  ^~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/functioncolumn.h:32,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_repeat.cpp:30:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:108:13: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   108 |     virtual const bool returnAll() const
       |             ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:117:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   117 |     const uint32_t sessionID() const
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:126:12: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   126 |     inline const int32_t sequence() const
       |            ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:162:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   162 |     const uint32_t expressionId() const
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:180:13: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   180 |     virtual const bool asc() const
       |             ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:189:13: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   189 |     virtual const bool nullsFirst() const
       |             ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/returnedcolumn.h:230:18: warning: 'virtual void execplan::ReturnedColumn::hasAggregate(bool)' was hidden [-Woverloaded-virtual]
   230 |     virtual void hasAggregate(bool hasAgg)
       |                  ^~~~~~~~~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_repeat.cpp:30:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/functioncolumn.h:159:18: warning:   by 'virtual bool execplan::FunctionColumn::hasAggregate()' [-Woverloaded-virtual]
   159 |     virtual bool hasAggregate();
       |                  ^~~~~~~~~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/messageqcpp/bytestream.h:38,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:44,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/treenode.h:35,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/parsetree.h:31,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:32,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:26,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_repeat.cpp:29:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp: In instantiation of 'struct static_any::anyimpl::typed_base_any_policy<static_any::anyimpl::empty_any>':
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:69:12:   required from 'struct static_any::anyimpl::big_any_policy<static_any::anyimpl::empty_any>'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:143:48:   required from 'static_any::anyimpl::base_any_policy* static_any::anyimpl::get_policy() [with T = static_any::anyimpl::empty_any]'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:166:54:   required from here
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:35:12: warning: base class 'struct static_any::anyimpl::base_any_policy' has accessible non-virtual destructor [-Wnon-virtual-dtor]
    35 |     struct typed_base_any_policy : base_any_policy
       |            ^~~~~~~~~~~~~~~~~~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:35:12: warning: 'struct static_any::anyimpl::typed_base_any_policy<static_any::anyimpl::empty_any>' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp: In instantiation of 'struct static_any::anyimpl::big_any_policy<static_any::anyimpl::empty_any>':
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:143:48:   required from 'static_any::anyimpl::base_any_policy* static_any::anyimpl::get_policy() [with T = static_any::anyimpl::empty_any]'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:166:54:   required from here
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:69:12: warning: base class 'struct static_any::anyimpl::typed_base_any_policy<static_any::anyimpl::empty_any>' has accessible non-virtual destructor [-Wnon-virtual-dtor]
    69 |     struct big_any_policy : typed_base_any_policy<T>
       |            ^~~~~~~~~~~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:69:12: warning: 'struct static_any::anyimpl::big_any_policy<static_any::anyimpl::empty_any>' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp: In instantiation of 'struct static_any::anyimpl::typed_base_any_policy<const char*>':
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:44:12:   required from 'struct static_any::anyimpl::small_any_policy<const char*>'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:143:48:   required from 'static_any::anyimpl::base_any_policy* static_any::anyimpl::get_policy() [with T = const char*]'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:204:40:   required from 'static_any::any& static_any::any::assign(const T&) [with T = const char*]'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:174:17:   required from here
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:35:12: warning: base class 'struct static_any::anyimpl::base_any_policy' has accessible non-virtual destructor [-Wnon-virtual-dtor]
    35 |     struct typed_base_any_policy : base_any_policy
       |            ^~~~~~~~~~~~~~~~~~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:35:12: warning: 'struct static_any::anyimpl::typed_base_any_policy<const char*>' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp: In instantiation of 'struct static_any::anyimpl::small_any_policy<const char*>':
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:143:48:   required from 'static_any::anyimpl::base_any_policy* static_any::anyimpl::get_policy() [with T = const char*]'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:204:40:   required from 'static_any::any& static_any::any::assign(const T&) [with T = const char*]'
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:174:17:   required from here
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:44:12: warning: base class 'struct static_any::anyimpl::typed_base_any_policy<const char*>' has accessible non-virtual destructor [-Wnon-virtual-dtor]
    44 |     struct small_any_policy : typed_base_any_policy<T>
       |            ^~~~~~~~~~~~~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:44:12: warning: 'struct static_any::anyimpl::small_any_policy<const char*>' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
 [ 29%] Building CXX object storage/columnstore/columnstore/utils/funcexp/CMakeFiles/funcexp.dir/func_replace.cpp.o
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/messageqcpp/bytestream.h:38,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:44,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/treenode.h:35,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/parsetree.h:31,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:32,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:26,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_replace.cpp:27:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/common/any.hpp:24:12: warning: 'struct static_any::anyimpl::base_any_policy' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
    24 |     struct base_any_policy
       |            ^~~~~~~~~~~~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/treenode.h:35,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/parsetree.h:31,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:32,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:26,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_replace.cpp:27:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:553:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   553 |     const OID lookupTableOID(const TableName& tableName);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:559:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   559 |     const OID lookupOID(const TableColName& tableColName);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:591:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   591 |     const uint64_t nextAutoIncrValue ( TableName tableName);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:609:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   609 |     const OID colBitmap(const OID& oid) const;
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:615:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   615 |     const SCN scn(void) const;
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:627:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   627 |     const int colNumbers(const TableName& tableName);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:651:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   651 |     const RID constraintRID(const std::string constraintName);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:669:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   669 |     const RID constraintColRID(const TableColName& tableColName);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:815:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   815 |     const uint32_t sessionID() const
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:826:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   826 |     const int identity() const
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:839:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   839 |     const int colPosition (const OID& oid);
       |     ^~~~~
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/calpontsystemcatalog.h:852:5: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   852 |     const int getTableCount ();
       |     ^~~~~
 In file included from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/parsetree.h:31,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor.h:32,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/functor_str.h:26,
                  from /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/utils/funcexp/func_replace.cpp:27:
 /builds/mariadb-team/mariadb-server/storage/columnstore/columnstore/dbcon/execplan/treenode.h: In member function 'virtual void execplan::TreeNode::operationType(const Type&)':



 Comments   
Comment by Otto Kekäläinen [ 2020-06-19 ]

drrtuy Can you help with this? What build option should I use to get a less verbose build?

Comment by Roman [ 2020-06-19 ]

otto I've asked ben.thompson to share his progress on this issue.

Comment by Ben Thompson (Inactive) [ 2020-06-24 ]

Sorry for the delay. This was also in linked issue MCOL-4030. It is under review now. If accepted number of warnings should go from around 13,000 to less than 100. Some of the remaining ones are to be resolved later.

Comment by Patrick LeBlanc (Inactive) [ 2020-06-24 ]

I'll go ahead and close this one since it's a dup of MCOL-4030. Please continue work under that ticket.

Comment by Patrick LeBlanc (Inactive) [ 2020-06-24 ]

Dup of MCOL-4030

Generated at Thu Feb 08 02:47:32 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.