[MCOL-4059] Commands have suffixes in vain Created: 2020-06-15  Updated: 2023-10-25

Status: Open
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: None
Fix Version/s: 23.10

Type: Bug Priority: Minor
Reporter: Otto Kekäläinen Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None


 Description   

There are a lot of shell scripts that are installed as system wide programs in /usr/bin or /usr/sbin, but still using their .sh suffix. This is against general practice. Users don't need to know or care if a command is implemented in C, Perl, Shell or whatever.

These should be changed to not have the .sh when installed:

usr/bin/MCSInstanceCmds.sh
usr/bin/MCSVolumeCmds.sh
usr/bin/MCSgetCredentials.sh
usr/bin/alarmReport.sh
usr/bin/bulklogReport.sh
usr/bin/columnstoreClusterTester.sh
usr/bin/columnstoreSyslogSetup.sh
usr/bin/columnstore_module_installer.sh
usr/bin/columnstore_os_check.sh
usr/bin/columnstore_run.sh
usr/bin/configReport.sh
usr/bin/configxml.sh
usr/bin/disable-rep-columnstore.sh
usr/bin/hardwareReport.sh
usr/bin/logReport.sh
usr/bin/mariadb-columnstore-start.sh
usr/bin/mariadb-columnstore-stop.sh
usr/bin/mariadb-command-line.sh
usr/bin/master-rep-columnstore.sh
usr/bin/mcs-loadbrm.py
usr/bin/mcs-start-storagemanager.py
usr/bin/mcs-stop-controllernode.sh
usr/bin/mcs_module_installer.sh
usr/bin/os_detect.sh
usr/bin/quick_installer_multi_server.sh
usr/bin/quick_installer_single_server.sh
usr/bin/remote_command.sh
usr/bin/remote_command_verify.sh
usr/bin/remote_scp_get.sh
usr/bin/remote_scp_put.sh
usr/bin/resourceReport.sh
usr/bin/rsync.sh
usr/bin/slave-rep-columnstore.sh
usr/bin/softwareReport.sh
usr/bin/startupTests.sh
usr/sbin/install_mcs_mysql.sh

Also the issue MCOL-4058 applies here as well. You can't have generic commands like /usr/bin/rsync.sh installed system wide, and you should not be using capitals in commands.



 Comments   
Comment by Daniel Black [ 2020-06-30 ]

Also while renaming suggest taking a more MCS branded approach with some of the names. Generic names like configReport are likely to conflict with other packages.

Generated at Thu Feb 08 02:47:28 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.