[MCOL-4042] MODA function memory leak Created: 2020-06-05 Updated: 2020-06-22 Due: 2020-06-05 Resolved: 2020-06-22 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | ExeMgr |
| Affects Version/s: | 1.4.3, 1.5.2 |
| Fix Version/s: | 1.5.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | David Hall (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
The UDAF MODA creates a hashmap that it doesn't clean up. |
| Comments |
| Comment by David Hall (Inactive) [ 2020-06-05 ] |
|
This turned out to be a bit more complex than a simple delete. |
| Comment by Patrick LeBlanc (Inactive) [ 2020-06-10 ] |
|
When you can, don't forget to create PRs for the other branches affected by this. 1.4, and possibly 1.2. |
| Comment by David Hall (Inactive) [ 2020-06-16 ] |
|
Tested in valgrind – no leaks. |
| Comment by Daniel Lee (Inactive) [ 2020-06-22 ] |
|
Build verified: 1.5.2-1 (community server b33685) Run a moda() test on a 1gb dbt3 database: SELECT MODA(l_extendedprice) FROM lineitem; Release 1.5.2-1 used less than 1/2 of memory used in 1.4.3-6 1.5.2-1 [centos7:root~]# cat top.log |grep "KiB Mem :" > memStats.txt used: 345916 1.4.3-6 [centos7:root~]# head -n 1 memStats.txt used: 790016 |