columnstore64.patch
|
Blocks |
|||
| blocks |
|
test columnstore for 10.5 | Closed |
[MCOL-4010] MCS fails to build on x86 with -Werror Created: 2020-05-19 Updated: 2020-06-02 Resolved: 2020-06-02 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 1.5.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Sergei Golubchik | Assignee: | Roman |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
columnstore64.patch
|
||||||||
| Issue Links: |
|
||||||||
| Sprint: | 2020-7 | ||||||||
| Description |
|
this is mainly type differences in printf formats and casts, and signed/unsigned comparisons (the latter isn't x86 only issue). The patch is attached. tested on xenial-i386 and xenial-amd64. the main issue was that int64_t is defined as long on amd64 and longlong on x86. This means neither "%ld" nor "%lld" will work on all platforms. |
| Comments |
| Comment by Patrick LeBlanc (Inactive) [ 2020-06-01 ] |
|
I merged the patch, the PR is here |
| Comment by Roman [ 2020-06-02 ] |
|
Nothing to test here. |