[MCOL-4003] Thread Concurrency Variables Not Limiting When Set to 20 Created: 2020-05-14 Updated: 2022-02-22 Resolved: 2022-02-22 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | Storage Manager |
| Affects Version/s: | None |
| Fix Version/s: | Icebox |
| Type: | Bug | Priority: | Major |
| Reporter: | Rupert Harwood (Inactive) | Assignee: | Ben Thompson (Inactive) |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
Note: Im splitting this out from the previous bug to be its own issue for tracking purposes. We found a bug in the config listeners for Downloader and Synchronizer, where if the config file has max_concurrent_uploads/downloads = 20, those thread pools never have a limit imposed on start. If the OS decides we've started too many threads too fast, or we hit a thread limit, that could cause a wide range of problems. Still, a scan through the code looking for races would be justified This only applies to the value of 20 for each variable (max_concurrent_uploads|max_concurrent_downloads). Setting the variable to any other value will bypass the issue and apply the limit. |
| Comments |
| Comment by Patrick LeBlanc (Inactive) [ 2020-05-19 ] |
|
For the time being, I changed the defaults in the config file to 21. The code fix is simple, but I can't take time to make sure it's bulletproof right now. |
| Comment by Rupert Harwood (Inactive) [ 2020-08-24 ] |
|
Note: Issue remain major despite support tickets being resolved. |