[MCOL-398] remove the restriction in postConfigure for UM memory at 16G Created: 2016-11-09 Updated: 2016-12-06 Resolved: 2016-12-06 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | None |
| Affects Version/s: | 1.0.4 |
| Fix Version/s: | 1.0.6 |
| Type: | Bug | Priority: | Minor |
| Reporter: | David Hill (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 2016-23, 2016-24 |
| Description |
|
remove the restriction in postConfigure for UM memory at 16G. This was done at IDB, but should be removed and allow it to be set to a higher range..This is set by % in postConfigure |
| Comments |
| Comment by David Hill (Inactive) [ 2016-11-09 ] |
|
check both the code and the documentation |
| Comment by David Hill (Inactive) [ 2016-11-11 ] |
|
fyi - this is for single-server install only, the restiction and change, that is |
| Comment by David Hill (Inactive) [ 2016-12-03 ] |
|
Update oamapps/postconfigure/installer.cpp ( used for single-server installer) to just use percentages and not GB and removed the limit on the numerb of GBS for UMmemory. did check into develop see it was a few line change in 1 source. commit ef3fe34af15c58d9b86cd68b5425cfe4843dcaab oamapps/postConfigure/installer.cpp | 59 +++++------------------------------------------------------ |
| Comment by David Hill (Inactive) [ 2016-12-03 ] |
|
please review, simple changes of going from GB to percentage for UMmemory setting. also removed the limit. |
| Comment by David Hill (Inactive) [ 2016-12-03 ] |
|
to test, need to do a single-server install on a server with memory larger than 64gb... removed the limit of 16GB for single-server UM memory. Also now setting in percent instead of GB, this could be checked by looking at the Columnstore.xml file |
| Comment by Daniel Lee (Inactive) [ 2016-12-06 ] |
|
Build tested: source from Github [root@localhost mariadb-columnstore-server]# git show Merge pull request #18 from mariadb-corporation/ [root@localhost mariadb-columnstore-server]# cd mariadb-columnstore-engine/ Merge pull request #66 from mariadb-corporation/ On a single server test, TotalUMMemory was set to 25, missing the % sign and caused tests to fail. |
| Comment by David Hill (Inactive) [ 2016-12-06 ] |
|
additional fixed checked into develop to fix issue, change to have it use the % number.. commit 43da90ae79651dbcfb8aaa4649049a22700030c7 change TotalUmMemory setting to a percentage oamapps/postConfigure/installer.cpp | 6 +++--- |
| Comment by David Hill (Inactive) [ 2016-12-06 ] |
|
please review, just changed to use a hardware code value number with the % for TotalUmMemory, previously I left off the "%" sign |
| Comment by Ben Thompson (Inactive) [ 2016-12-06 ] |
|
Review complete. |
| Comment by Daniel Lee (Inactive) [ 2016-12-06 ] |
|
Build verified: getsoftwareinfo Tue Dec 6 17:19:12 2016 Name : mariadb-columnstore-platform Also tested on the ovh servers, which have 64gb memory. With 1um2pm installation, the totalummemory was set at 50%. It used to set at a max of 16gb. |