[MCOL-398] remove the restriction in postConfigure for UM memory at 16G Created: 2016-11-09  Updated: 2016-12-06  Resolved: 2016-12-06

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: 1.0.4
Fix Version/s: 1.0.6

Type: Bug Priority: Minor
Reporter: David Hill (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2016-23, 2016-24

 Description   

remove the restriction in postConfigure for UM memory at 16G. This was done at IDB, but should be removed and allow it to be set to a higher range..This is set by % in postConfigure



 Comments   
Comment by David Hill (Inactive) [ 2016-11-09 ]

check both the code and the documentation

Comment by David Hill (Inactive) [ 2016-11-11 ]

fyi - this is for single-server install only, the restiction and change, that is

Comment by David Hill (Inactive) [ 2016-12-03 ]

Update oamapps/postconfigure/installer.cpp ( used for single-server installer) to just use percentages and not GB and removed the limit on the numerb of GBS for UMmemory.

did check into develop see it was a few line change in 1 source.

commit ef3fe34af15c58d9b86cd68b5425cfe4843dcaab
Author: david hill <david.hill@mariadb.com>
Date: Sat Dec 3 02:16:04 2016 +0000

MCOL-398

oamapps/postConfigure/installer.cpp | 59 +++++------------------------------------------------------
1 file changed, 5 insertions, 54 deletions

Comment by David Hill (Inactive) [ 2016-12-03 ]

please review, simple changes of going from GB to percentage for UMmemory setting. also removed the limit.

Comment by David Hill (Inactive) [ 2016-12-03 ]

to test, need to do a single-server install on a server with memory larger than 64gb... removed the limit of 16GB for single-server UM memory. Also now setting in percent instead of GB, this could be checked by looking at the Columnstore.xml file

Comment by Daniel Lee (Inactive) [ 2016-12-06 ]

Build tested: source from Github

[root@localhost mariadb-columnstore-server]# git show
commit 3795bd4cf42d59b792c473101703911fb53e9297
Merge: 570184c 84714c9
Author: dhall-InfiniDB <david.hall@mariadb.com>
Date: Wed Nov 30 11:42:14 2016 -0600

Merge pull request #18 from mariadb-corporation/MCOL-424

MCOL-424 Disable indexes for cross-engine

[root@localhost mariadb-columnstore-server]# cd mariadb-columnstore-engine/
[root@localhost mariadb-columnstore-engine]# git show
commit af58b880e91f6d9cbc502ae139b2064c7f79a9d7
Merge: 1e472ab 52fd60f
Author: dhall-InfiniDB <david.hall@mariadb.com>
Date: Mon Dec 5 13:20:25 2016 -0600

Merge pull request #66 from mariadb-corporation/MCOL-430

MCOL-430 Fix memory corruption in cross-engine

On a single server test, TotalUMMemory was set to 25, missing the % sign and caused tests to fail.

Comment by David Hill (Inactive) [ 2016-12-06 ]

additional fixed checked into develop to fix issue, change to have it use the % number..

commit 43da90ae79651dbcfb8aaa4649049a22700030c7
Author: David Hill <david.hill@mariadb.com>
Date: Tue Dec 6 15:41:44 2016 +0000

change TotalUmMemory setting to a percentage

oamapps/postConfigure/installer.cpp | 6 +++---
oamapps/postConfigure/postConfigure.cpp | 2 +-
2 files changed, 4 insertions, 4 deletions

Comment by David Hill (Inactive) [ 2016-12-06 ]

please review, just changed to use a hardware code value number with the % for TotalUmMemory, previously I left off the "%" sign

Comment by Ben Thompson (Inactive) [ 2016-12-06 ]

Review complete.

Comment by Daniel Lee (Inactive) [ 2016-12-06 ]

Build verified:

getsoftwareinfo Tue Dec 6 17:19:12 2016

Name : mariadb-columnstore-platform
Version : 1.0.6
Release : 1
Architecture: x86_64
Install Date: Tue 06 Dec 2016 01:50:33 PM EST
Group : Applications/Databases
Size : 10020591
License : Copyright (c) 2016 MariaDB Corporation Ab., all rights reserved; redistributable under the terms of the GPL, see the file COPYING for details.
Signature : (none)
Source RPM : mariadb-columnstore-platform-1.0.6-1.src.rpm
Build Date : Tue 06 Dec 2016 01:13:20 PM EST
Build Host : ip-172-30-0-125.us-west-2.compute.internal

Also tested on the ovh servers, which have 64gb memory. With 1um2pm installation, the totalummemory was set at 50%. It used to set at a max of 16gb.

Generated at Thu Feb 08 02:20:46 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.