[MCOL-3904] Group_concat order by with long double fails Created: 2020-03-26  Updated: 2020-11-12  Resolved: 2020-05-01

Status: Closed
Project: MariaDB ColumnStore
Component/s: ExeMgr
Affects Version/s: 1.2.5
Fix Version/s: 1.2.6, 1.4.4, 1.5.1

Type: Bug Priority: Minor
Reporter: David Hall (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2020-5, 2020-6, 2020-7

 Description   

A group_concat call with a subselected SUM (or AVG) in the order by phrase wil fail with
"ERROR 1815 (HY000): Internal error: IDB-2035: An internal error occurred. Check the error log file & contact support."

debug.log will contain "/home/calpont/mariadb/engine/utils/rowgroup/rowgroup.h@726: assertion '0' failed"

The problem is that the order by portion of group_concat is not long double aware.

 Comments   
Comment by David Hall (Inactive) [ 2020-03-26 ]

QA: The following query broke before this patch:
select group_concat(o_orderpriority order by m1 desc) as grouped_pri from (select o_orderpriority, sum(o_totalprice) as m1 from orders where o_orderkey < 1000 group by 1) as s1;

Comment by David Hall (Inactive) [ 2020-03-26 ]

regression test in develop

Comment by Patrick LeBlanc (Inactive) [ 2020-03-26 ]

merged the code, waiting on regression test for 1.2 and 1.4

Comment by David Hall (Inactive) [ 2020-04-13 ]

Added tests for 1.2, 1.4 and 1.5. PR #213, 212 and 211 respectively.

Comment by Daniel Lee (Inactive) [ 2020-05-01 ]

Builds verified: 1.2.6-1, 1.4.4-1, 1.5.0-1 source

1.2.6-1

/root/ColumnStore/buildColumnstoreFromGithubSource/mariadb-columnstore-server
commit d3294cf9c18663673c62532dddaa11369ba184d0
Merge: 2ef719d c5be945
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Thu Oct 31 15:06:48 2019 +0000

commit 4db1eb1f71aaafd375a332c55d72a80c8d14f145
Merge: d5179a1 bb2ad91
Author: Patrick LeBlanc <43503225+pleblanc1976@users.noreply.github.com>
Date: Fri May 1 09:33:48 2020 -0500

1.4.4-1

/root/ColumnStore/buildColumnstoreFromGithubSource/server
commit 00abe03ad1da3719e06f7112000a331ee2b6786a
Author: Patrick LeBlanc <43503225+pleblanc1976@users.noreply.github.com>
Date: Wed Apr 29 10:00:54 2020 -0500

/root/ColumnStore/buildColumnstoreFromGithubSource/server/engine
commit 2b67ac7f3537bd4b4d132c8a6c3a53e4cc63f4a1
Merge: beaac49 23d65dc
Author: benthompson15 <ben.thompson.015@gmail.com>
Date: Tue Apr 28 15:40:45 2020 -0500

1.5.0-1

/root/ColumnStore/buildColumnstoreFromGithubSource/server
commit 25eb50d6c002e987e2d240402391549d408c18d9
Author: Alexey Bychko <abychko@gmail.com>
Date: Thu Apr 23 12:36:13 2020 +0700

commit 6ad38ccc28d31a099d052e5de827543808843a3c
Merge: 658abae bb3e76b
Author: benthompson15 <ben.thompson.015@gmail.com>
Date: Fri Apr 24 14:31:09 2020 -0500

Generated at Thu Feb 08 02:46:20 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.