[MCOL-39] console command "getSystemConfig" return API for some parameter names Created: 2016-05-05  Updated: 2023-10-26  Resolved: 2016-08-02

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: None
Fix Version/s: 1.0.2

Type: Bug Priority: Minor
Reporter: Daniel Lee (Inactive) Assignee: Ben Thompson (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 1.0.2-2

 Description   

"getSystemConfig" or "getSystemConfig all" returned all parameters as expected. But when trying to return individual parameters values, some of the failed.

InfiniDB> getsystemconfig
getsystemconfig Thu May 5 16:10:11 2016

System Configuration

SystemName = calpont-1
SoftwareVersion = 5.0
SoftwareRelease = 0
ParentOAMModuleName = pm1
StandbyOAMModuleName = pm2
NMSIPAddr = 0.0.0.0
ModuleHeartbeatPeriod = 1
ModuleHeartbeatCount = 3
DBRootCount = 2
DBRoot1 = /usr/local/Calpont/data1
DBRoot2 = /usr/local/Calpont/data2
DBRMRoot = /usr/local/Calpont/data1/systemFiles/dbrm/BRM_saves
ExternalCriticalThreshold = 90
ExternalMajorThreshold = 80
ExternalMinorThreshold = 70
MaxConcurrentTransactions = 1000
SharedMemoryTmpFile =
NumVersionBufferFiles = 0
VersionBufferFileSize = 1
OIDBitmapFile = /usr/local/Calpont/data1/systemFiles/dbrm/oidbitmap
FirstOID = 3000
TransactionArchivePeriod = 10
InfiniDB>
InfiniDB> getsystemconfig NumVersionBufferFiles
getsystemconfig Thu May 5 16:10:18 2016

        • getSystemConfig Failed : Invalid Parameter passed in getSystemConfig API
          InfiniDB> getsystemconfig SharedMemoryTmpFile
          getsystemconfig Thu May 5 16:10:24 2016
        • getSystemConfig Failed : Invalid Parameter passed in getSystemConfig API
          InfiniDB>

If these parameters are not defined in the system, then we should return as such.



 Comments   
Comment by David Hill (Inactive) [ 2016-08-02 ]

After investigtaing the issue and discussing with Daniel, I'm going to remove the commands getsystemconfig and setsystemconfig as the fix for this issue. These were originally added so a user could use the get to display the system configuration parameters and use the set to change them. BUT there are a number of system parameters we don't want to user to change. So it's best to just remove these instead of trying to update them to make them accurately show the correct parameters. The recommended way to change a parameter is using the setConfig.sh command.

Plus I'm pretty sure there aren't any customers that ever used this to display or set the parmaters. So removing them will not impact anybody, but we can document in the readme that they are removed and they can use the getConfig and setConfig scripts instead.

Comment by David Hill (Inactive) [ 2016-08-02 ]

please review, easy review. removed 2 commands from mcsadmin console

getsystemconfig
setsystemconfig

commit 60fe260033bfb70d8909d44b560b546521ebf49a
Author: david hill <david.hill@mariadb.com>
Date: Tue Aug 2 11:51:44 2016 -0500

mcol-39

oam/etc/ConsoleCmds.xml | 11 +----
oamapps/mcsadmin/mcsadmin.cpp | 98 +----------------------------------------
2 files changed, 4 insertions, 105 deletions

Comment by Ben Thompson (Inactive) [ 2016-08-02 ]

Review Completed

Generated at Thu Feb 08 02:18:03 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.