[MCOL-370] enableLog / disableLog don't work Created: 2016-10-20  Updated: 2023-10-26  Resolved: 2016-11-22

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.0.3
Fix Version/s: 1.0.5

Type: Bug Priority: Major
Reporter: David Thompson (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: relnote

Sprint: 2016-21, 2016-22, 2016-23

 Description   

the default syslog for column store is:

[root@centos7 rsyslog.d]# cat 49-columnstore.conf
 
# MariaDb Columnstore Database Platform Logging
 
local1.crit -/var/log/mariadb/columnstore/crit.log
 
local1.err -/var/log/mariadb/columnstore/err.log
 
local1.warning -/var/log/mariadb/columnstore/warning.log
 
local1.info -/var/log/mariadb/columnstore/info.log
 
local1.debug -/var/log/mariadb/columnstore/debug.log

I try to disable debug log:

[david@centos7 rsyslog.d]$ mcsadmin disablelog pm1 debug
 
disablelog   Wed Oct 19 06:38:24 2016
 
 
 
**** disableLog Failed :  API Failure return in updateLog API

failed ,no change to the columnstore.conf file

Enable goes ok:

[david@centos7 rsyslog.d]$ mcsadmin enablelog pm1 debug
 
enablelog   Wed Oct 19 06:39:15 2016
 
 
 
   Successful Enabling of Logging

But file update seems wrong:

[root@centos7 rsyslog.d]# cat 49-columnstore.conf
 
# MariaDb Columnstore Database Platform Logging
 
local1.crit -/var/log/mariadb/columnstore/crit.log
 
local1.err -/var/log/mariadb/columnstore/err.log
 
local1.warning -/var/log/mariadb/columnstore/warning.log
 
local1.info -/var/log/mariadb/columnstore/info.log
 
local1.debug -/var/log/mariadb/columnstore/debug.log
 
 
 
local1.=debug -/var/log/mariadb/columnstore/debug.log

disablelog now works removing the last line:

[david@centos7 rsyslog.d]$ mcsadmin disablelog pm1 debug
 
disablelog   Wed Oct 19 06:39:58 2016
 
 
 
   Successful Disabling of Logging

However none of this achieved what i want.

Looking at processmonitor.cpp, i can see that updateLog is looking for lines starting local2 not local1 which might be the cause of the problem.

A workaround is of course to just edit the log file directly.

 Comments   
Comment by David Thompson (Inactive) [ 2016-10-20 ]

in addition debug, info, and warning seem to log a fair bit and also duplicate entries between them so we should fix that and also maybe consider disabling debug at a minimum.

Comment by David Hill (Inactive) [ 2016-10-31 ]

please review, engine repo mcol-370..

Comment by Ben Thompson (Inactive) [ 2016-11-02 ]

Reviewed.

Comment by Daniel Lee (Inactive) [ 2016-11-22 ]

What was implemented for this ticket?
Did we fix the reported in the bug description?
Did we cleanup the locks by eliminating the duplicate entries among log files?
Did we disable the debug.log file?

Comment by Daniel Lee (Inactive) [ 2016-11-22 ]

Build tested: 1.0.5-1

mcsadmin> getsoft
getsoftwareinfo Tue Nov 22 10:13:49 2016

Name : mariadb-columnstore-platform
Version : 1.0.5
Release : 1
Architecture: x86_64
Install Date: Tue 22 Nov 2016 10:10:12 AM CST
Group : Applications/Databases
Size : 9990112
License : Copyright (c) 2016 MariaDB Corporation Ab., all rights reserved; redistributable under the terms of the GPL, see the file COPYING for details.
Signature : (none)
Source RPM : mariadb-columnstore-platform-1.0.5-1.src.rpm
Build Date : Mon 21 Nov 2016 07:29:37 PM CST

Enabling and disabling types of log files are not working.

Duplicated entries in multiple logs files have been an issue for a long time. We need better and precise messages in log files.

Closing this ticket for fixing the api issue for now.

Generated at Thu Feb 08 02:20:33 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.