Failed tests in the 001 suite in 1.4 (MCOL-3594)

[MCOL-3600] Create bit_count(), charset(), unhex() and minute() functions that doesn't exists in CS in 1.4 Created: 2019-11-08  Updated: 2020-04-09  Resolved: 2020-04-09

Status: Closed
Project: MariaDB ColumnStore
Component/s: ExeMgr
Affects Version/s: None
Fix Version/s: N/A

Type: Sub-Task Priority: Minor
Reporter: Roman Assignee: David Hall (Inactive)
Resolution: Not a Bug Votes: 0
Labels: None

Issue Links:
PartOf
includes MCOL-3634 Sleep function not supported in Colum... Closed
Sprint: 2020-1, 2020-2, 2020-3, 2020-4, 2020-5, 2020-6, 2020-7

 Description   

bit_count(), charset() and unhex() doesn't exist in CS thus couldn't be used in the query. CS used to utilize MDB functions for this in 1.2.
We should create these functions in utils/funcexp.



 Comments   
Comment by Gagan Goel (Inactive) [ 2020-03-11 ]

BIT_COUNT(), UNHEX(), MINUTE() functions already exist in ColumnStore. Here are the passing tests:

working_tpch1/qa_fe_cnxFunctions/unhex.sql
working_tpch1/qa_fe_cnxFunctions/BIT_COUNT.sql
working_tpch1/qa_fe_cnxFunctions/MINUTE.DS.sql

The reason MINUTE() function is wrongly included in this ticket is because the following test fails:
working_tpch1_compareLogOnly/misc/bug2891_negative.sql

The issue here is not the MINUTE() function, but the SLEEP() function which is wrapped around MINUTE(). ColumnStore does not yet support SLEEP(). MCOL-3634 is open for this.

For CHARSET() and COLLATION(), ColumnStore does not currently support setting character set and collation at the column level.

However, the PR https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/951 enabled support for CHARSET() and COLLATION() in the plugin code, which gets these values from the metadata of the table field. Associated passing test for these functions is:
working_tpch1/misc/MCOL-1535.sql

Setting CHARSET() and COLLATION() in the plugin code should suffice since for a given field, all rows should have the same value for these functions, and therefore there should be no need to implement these functions in ColumnStore.

Comment by Gagan Goel (Inactive) [ 2020-03-11 ]

Please review the above comment.

Generated at Thu Feb 08 02:43:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.