[MCOL-3563] cleanup compiler warnings / type errors in *Task classes Created: 2019-10-16 Updated: 2019-12-09 Resolved: 2019-12-09 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | Storage Manager |
| Affects Version/s: | 1.4.0 |
| Fix Version/s: | 1.4.2 |
| Type: | Task | Priority: | Major |
| Reporter: | Patrick LeBlanc (Inactive) | Assignee: | Patrick LeBlanc (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 2019-06 |
| Description |
|
Got a lot of legitimate compiler warnings building develop. PosixTask::read() returns an int, is assigned to a bool, and then there's a comparison 'if (bool < 0)', which is always false. So, there's currently no error handling for those read() calls. |
| Comments |
| Comment by Ben Thompson (Inactive) [ 2019-10-31 ] |
|
Fixed effected classes to handle errors correctly. Also worth noting the warning will not appear in centos7 with default compiler installed. Testing verified with regression and storagemanager unit tests. Only would've seen this if posix::read failed and other things would have failed if that were happening. |
| Comment by Daniel Lee (Inactive) [ 2019-12-09 ] |
|
Build verified: 1.4.2-1 source Server commit 6e1a53f89ee8d4eb9e66257b01898995aa7691de MENT-240 change plugin-maturity default to stable Engine /root/ColumnStore/buildColumnstoreFromGithubSource/server/engine Merge pull request #962 from jmrojas2332/ MCOL 3474 Fix TIMEDIFF w/ non-temporal data types Made the latest build with debug option on and capture all terminal output to a file. Verified that such messages are no longer outputted. |