[MCOL-344] Set test001 working_tpch1 to Tr mode Created: 2016-10-03  Updated: 2016-11-28  Resolved: 2016-11-28

Status: Closed
Project: MariaDB ColumnStore
Component/s: regression suite
Affects Version/s: None
Fix Version/s: 1.0.5

Type: Bug Priority: Major
Reporter: Andrew Hutchings (Inactive) Assignee: David Hall (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
PartOf
includes MCOL-334 Bad NULL match in view subquery Closed
Relates
relates to MCOL-345 Saturated time() func handling is dif... Closed
relates to MCOL-346 Saturated addtime() func handling is ... Closed
relates to MCOL-347 NULLIF datetime compare with date fails Closed
Sprint: 2016-19, 2016-20, 2016-21, 2016-22, 2016-23

 Description   

This is a continuation after MCOL-25 and MCOL-23. test001 should use Tr mode to test against the ref files. These are the current failures:

Compare failed - working_tpch1/aggregation/bitop.sql
Compare failed - working_tpch1/aggregation/funcCountCol_m.sql
Compare failed - working_tpch1/aggregation/funcGroupbyCol10Col_m.sql
Compare failed - working_tpch1/aggregation/funcGroupbyCol1Col_m.sql
Compare failed - working_tpch1/aggregation/funcGroupbyCol3Col_m.sql
Compare failed - working_tpch1/aggregation/funcGroupbyTable10Col_m.sql
Compare failed - working_tpch1/aggregation/funcGroupbyTable1Col_m.sql
Compare failed - working_tpch1/aggregation/funcGroupbyTable3Col_m.sql
Compare failed - working_tpch1/aggregation/funcMax_m.sql
Compare failed - working_tpch1/aggregation/funcMin_m.sql
Compare failed - working_tpch1/aggregation/group_concat.sql

Compare failed - working_tpch1/misc/bug2584.sql
Compare failed - working_tpch1/misc/bug2634.sql
Compare failed - working_tpch1/misc/bug3475.sql
Compare failed - working_tpch1/misc/bug3481.sql
Compare failed - working_tpch1/misc/bug3518.negative.sql
Compare failed - working_tpch1/misc/bug3670.negative.sql
Compare failed - working_tpch1/misc/bug3803.negative.sql
Compare failed - working_tpch1/misc/bug3881.sql
Compare failed - working_tpch1/misc/bug4767.negative.sql
Compare failed - working_tpch1/misc/bug4827.sql
Compare failed - working_tpch1/misc/bug5126.negative.sql
Compare failed - working_tpch1/misc/rename.negative.sql

Compare failed - working_tpch1/qa_fe_cnxFunctions/addtime.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/bug3333.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/bug3334_ceil.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/bug3334_overflow_error.negative.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/bug3584.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/bug3788.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/bug3792.negative.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/CASE1.SM.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/CASE2.SM.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/CAST.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/concat_ws.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/CONVERT.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/DAYNAME.DS.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/degrees.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/EXTRACT.DM.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/from_days.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/from_unixtime.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/insert.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/LOG2.NS.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/makedate.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/MONTHNAME.DS.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/NULLIF.DM.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/RADIANS.NS.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/repeat.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/SUBSTRING_INDEX.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/subtime.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/unix_timestamp.sql
Compare failed - working_tpch1/qa_fe_cnxFunctions/xor.sql.negative.sql

Compare failed - working_tpch1/qa_fe_postProcessedFunctions/CONCAT_WS.SM.sql
Compare failed - working_tpch1/qa_fe_postProcessedFunctions/LOG2.NS.sql
Compare failed - working_tpch1/qa_fe_postProcessedFunctions/SEC_TO_TIME.NS.sql

Compare failed - working_tpch1/view/view.sql

Many of these could be due to a needed ref update. All need analysing ASAP.



 Comments   
Comment by Andrew Hutchings (Inactive) [ 2016-10-03 ]

Analysis:

working_tpch1/aggregation/* - update ref

working_tpch1/misc/bug3881.sql - needs order by
working_tpch1/misc/bug4827.sql - needs order by
working_tpch1/misc/* - update refs

working_tpch1/qa_fe_cnxFunctions/bug3333.sql - bugs in time() handling
working_tpch1/qa_fe_cnxFunctions/bug3792.negative.sql - saturated addtime() shoud return NULL
working_tpch1/qa_fe_cnxFunctions/NULLIF.DM.sql - NULLIF on DATE and DATETIME fail
working_tpch1/qa_fe_cnxFunctions/* - update refs

working_tpch1/qa_fe_postProcessedFunctions/* - update refs

working_tpch1/view/view.sql - MCOL-334

I'll open required tickets tomorrow

Comment by Andrew Hutchings (Inactive) [ 2016-10-04 ]

Only NULLIF.DM.sql and view.sql are things we should be concerned about for Beta.

Comment by Andrew Hutchings (Inactive) [ 2016-10-08 ]

Pull request for the ref and query fixes can be found at:

https://github.com/mariadb-corporation/mariadb-columnstore-regression-test/pull/2

Comment by David Hall (Inactive) [ 2016-10-17 ]

I've changed a bunch of the tests in working_tpch1_compareLogOnly so they compare properly. Please review and merge.

We still need to change working_tpch1 to -r B, but I'm waiting on your opinion on what would break due to the changes you made.

Comment by Andrew Hutchings (Inactive) [ 2016-10-18 ]

If we do set it back to 'B' I highly recommend 'B' in local mode setting 'Tr' instead of 'T' like it does now. I'll merge your fixes and leave this assigned to me pending outcome of the discussion.

Comment by Andrew Hutchings (Inactive) [ 2016-10-27 ]

still some discussions and work to do

Comment by Andrew Hutchings (Inactive) [ 2016-11-24 ]

Switched working_tpch1 back to B mode instead of Tr so that we don't use the ref files in local mode.

Everything else should be good now I believe.

Generated at Thu Feb 08 02:20:21 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.