[MCOL-3438] make Ownership make sense wrt toolkit & improve smls output Created: 2019-08-16  Updated: 2019-09-20  Resolved: 2019-09-20

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: None
Fix Version/s: 1.4.0

Type: Task Priority: Minor
Reporter: Patrick LeBlanc (Inactive) Assignee: Ben Thompson (Inactive)
Resolution: Done Votes: 0
Labels: None

Epic Link: ObjectStore support

 Description   

Hacking on the SM toolkit. Realized the way Ownership works right now is making the paths nonsensical. As a minor optimization, I made Ownership::get() lop off the first X directories in the path b/c they would all be the same (/usr/local/mariadb/columnstore) theoretically. Not creating / storing / traversing those extra directories is a small time saver across the system.

However, when using the toolkit, you now have to prepend a bunch of nonsense directories. ex, 'smcat /1/2/3/4/file' instead of 'smcat file'.

The output of smls also needs to be changed s.t. the only files returned by the listing are .meta files. If it doesn't have a .meta extension and is not a directory, it should be left out of the output.

Another consideration wrt Ownership. If the toolkit is used on a node that doesn't own the specified prefix, and the storagemanager dirs are on a shared FS, the tool will grab ownership to perform the operation. Ex, running 'smls dir-owned-by-another-node' will take ownership temporarily. Need to think about how these concepts should coexist.



 Comments   
Comment by Patrick LeBlanc (Inactive) [ 2019-08-19 ]

On one hand, making these tools work is likely a 0.1% use case, on the other, it should still not be incomprehensible to a user. I think what I'll do is have the tools get the common prefix length from the config file, and prepend that # of bogus directories to their parameters.

Comment by Ben Thompson (Inactive) [ 2019-09-20 ]

Should have closed when PR was merged.

Generated at Thu Feb 08 02:42:44 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.