Setting the systemlang in Columnstore.xml to an unrecognized string will cause the system to not start due to an uncaught exception crashing WorkerNode.

In utils/funcexp/utilsutf8..h, idb_setlocale() attempts to set the C++ locale with the return value from setlocale(). If setlocale() fails, which it will with a bad string, then the c++ locale is set with a NULL string, which throws. We need to do the c++ locale after we test for NULL.

QA: To test, set systemlang in the XML to something not accepted. I used "Bogus"
Try to start the system.
Broken = never start. Possible continuous restart of ProcMgr.

Fixed: Should start up, raise an alarm and log "Failed to set locale Bogus : Setting to 'C'. Critical alarm generated"

Build verified: 1.5.0-1 BB

engine commit:
f01185f

1.4.4-1 is not yet available in buildbot.

crit.log

Mar 17 18:26:57 localhost ProcessManager[12140]: 57.944436 |0|0|0| E 17 CAL0001: Failed to set locale aloha : Setting to 'C'. Critical alarm generated
Mar 17 18:27:00 localhost ProcessManager[12201]: 00.024550 |0|0|0| E 17 CAL0001: Failed to set locale aloha : Setting to 'C'. Critical alarm generated
Mar 17 18:27:04 localhost ProcessManager[12234]: 04.075806 |0|0|0| E 17 CAL0001: Failed to set locale aloha : Setting to 'C'. Critical alarm generated

Critical Active Alarms:

AlarmID = 36
Brief Description = INVALID_LOCALE
Alarm Severity = CRITICAL
Time Issued = Tue Mar 17 18:26:57 2020
Reporting Module = pm1
Reporting Process = DBRMControllerNode
Reported Device = system

Build verified: 1.4.4.-1 source

/root/ColumnStore/buildColumnstoreFromGithubSource/server
commit 86a634a0feaf7788c9bcf7cc763e500d2be97d75
Author: Sergei Golubchik <serg@mariadb.org>
Date: Fri Feb 28 21:55:32 2020 +0100

Revert "make columnstore maturity gamma"

This reverts commit e4a0372cd08a53f97a62d6b6ef32114b553cacb7.

/root/ColumnStore/buildColumnstoreFromGithubSource/server/engine
commit ca3e2d78d6e1d06fb6711befe7bb2d618e801929
Merge: ec3630d f437152
Author: Patrick LeBlanc <43503225+pleblanc1976@users.noreply.github.com>
Date: Thu Mar 19 11:43:55 2020 -0500

Merge pull request #1113 from pleblanc1976/develop-1.4

Bumped version num to 1.4.4-1