[MCOL-318] switch to using os distribution version of snappy Created: 2016-09-23  Updated: 2017-05-22  Resolved: 2017-05-22

Status: Closed
Project: MariaDB ColumnStore
Component/s: Build
Affects Version/s: 1.0.3
Fix Version/s: 1.1.0

Type: Bug Priority: Major
Reporter: David Thompson (Inactive) Assignee: David Hill (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2017-01, 2017-2, 2017-3, 2017-4, 2017-5, 2017-6, 2017-7, 2017-8, 2017-9, 2017-10

 Description   

Currently snappy is directly included in the column store builds. We should switch to depending on the os distribution version to keep up on improvements and security fixes.

Since this is used for the column data compression, need to investigate if this triggers any sort of change in format or behavior that would require data migration as part of upgrade.

 Comments   
Comment by Andrew Hutchings (Inactive) [ 2016-11-07 ]

there don't appear to be any security fixes so far, but the latest version is up to 800% faster when detecting uncompressible data

Comment by Andrew Hutchings (Inactive) [ 2017-01-17 ]

Set to Ben for review as this is mostly just a build change.

For test, passing the regression suite is enough.

We also need to document the following:

  • For build libsnappy-dev for Debian/Ubuntu or snappy-devel for RedHat/CentOS is required
  • For install snappy1v5 for Ubuntu (I'm guessing Debian too) or snappy for RedHat/CentOS is required

Targeting 1.1 only

Comment by David Hall (Inactive) [ 2017-01-19 ]

There's no mention of Snappy in the README.md file. I found no snappy on my CentOS 6.5 or Ubuntu 14.04. I realize these are old distributions, but should it not be listed in the dependencies?

Comment by Andrew Hutchings (Inactive) [ 2017-01-19 ]

CentOS 6.x does have it in the main repository under the name 'snappy' with the headers in 'snappy-devel'.

Ubuntu 14.04 is not one of our supported platforms as far as I can tell but it is in the 'universe' repository for that OS which may not be enabled by default.

The README.md in the engine doesn't specify dependencies. That is something for the server tree, hence my note that there needs to be follow-up documentation.

Comment by Ben Thompson (Inactive) [ 2017-01-21 ]

Reviewed build changes, all looks good.

Comment by Daniel Lee (Inactive) [ 2017-05-05 ]

Assigned to Mr. Hill for regression tests.

Comment by David Thompson (Inactive) [ 2017-05-22 ]

THis is complete

Generated at Thu Feb 08 02:20:09 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.