[MCOL-284] Comment parser in MCOL-256 breaks some queries Created: 2016-09-06 Updated: 2016-09-20 Resolved: 2016-09-20 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | ExeMgr |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Andrew Hutchings (Inactive) | Assignee: | David Hill (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Sprint: | 1.0.3 | ||||||||||||||||
| Description |
|
The detection I added checks for double dash, but it should check for double dash followed by whitespace. The current detection currently breaks working_tpch1/qa_fe_cnxFunctions/DATE_* |
| Comments |
| Comment by Andrew Hutchings (Inactive) [ 2016-09-06 ] |
|
I'm not the only one to make this mistake, VIM syntax highlighting also gets this wrong! |
| Comment by Andrew Hutchings (Inactive) [ 2016-09-06 ] |
|
Fix is at https://github.com/mariadb-corporation/mariadb-columnstore-server/pull/5 No need for additional QA, current regression suite will hit it. |
| Comment by Daniel Lee (Inactive) [ 2016-09-13 ] |
|
I don't have the regression test suite setup on my VMs yet. I assigned the ticket to Mr. Hill so he can close it if it works in regression. Thanks |
| Comment by David Thompson (Inactive) [ 2016-09-20 ] |
|
Regression suite test is now passing so this is verified. |