[MCOL-258] Window function create is hidden Created: 2016-07-28  Updated: 2018-01-19  Resolved: 2018-01-19

Status: Closed
Project: MariaDB ColumnStore
Component/s: MariaDB Server
Affects Version/s: 1.0.1
Fix Version/s: 1.1.3

Type: Bug Priority: Minor
Reporter: David Hall (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

Any linux

Sprint: 2017-25, 2018-01, 2018-02

 Description   

The following warnings are generated when building the columnstore server. This is likely due to a incorrect function definition. It may cause hidden problems, or it may not. Either way, we strive to create warning free code.

In file included from /home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:29:0:
/home/david/mariadb-columnstore-server/sql/item_create_window_function.h:72:16: warning: ‘virtual Item* Create_window_func_arg0::create(THD*, LEX_STRING, List<Item>*)’ was hidden [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name, List<Item> *item_list)
^
/home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:69:16: warning: by ‘virtual Item* Create_window_func_rank::create(THD*, LEX_STRING)’ [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name)
^
In file included from /home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:29:0:
/home/david/mariadb-columnstore-server/sql/item_create_window_function.h:72:16: warning: ‘virtual Item* Create_window_func_arg0::create(THD*, LEX_STRING, List<Item>*)’ was hidden [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name, List<Item> *item_list)
^
/home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:87:16: warning: by ‘virtual Item* Create_window_func_rownumber::create(THD*, LEX_STRING)’ [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name)
^
In file included from /home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:29:0:
/home/david/mariadb-columnstore-server/sql/item_create_window_function.h:116:16: warning: ‘virtual Item* Create_window_func_arg1::create(THD*, LEX_STRING, List<Item>*)’ was hidden [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name, List<Item> *item_list)
^
/home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:231:16: warning: by ‘virtual Item* Create_window_func_median::create(THD*, LEX_STRING, Item*)’ [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name, Item *arg1)
^
In file included from /home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:29:0:
/home/david/mariadb-columnstore-server/sql/item_create_window_function.h:116:16: warning: ‘virtual Item* Create_window_func_arg1::create(THD*, LEX_STRING, List<Item>*)’ was hidden [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name, List<Item> *item_list)
^
/home/david/mariadb-columnstore-server/sql/item_create_window_function.cc:248:16: warning: by ‘virtual Item* Create_window_func_ntile::create(THD*, LEX_STRING, Item*)’ [-Woverloaded-virtual]
virtual Item *create(THD *thd, LEX_STRING name, Item *arg1)

 Comments   
Comment by David Hall (Inactive) [ 2018-01-09 ]

There's no need to propagate this up, as the classes in question have been replaced.

Comment by Daniel Lee (Inactive) [ 2018-01-19 ]

Build verified: 1.1.3-1, Github source

[root@localhost ~]# cat mariadb-columnstore-1.1.3-1-centos7.x86_64.bin.tar.txt
/root/columnstore/mariadb-columnstore-server
commit e0ae0d2fecf9941887478d9aa669c8b2d1092090
Merge: 21ec501 2490ddf
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Fri Jan 19 12:39:05 2018 -0600

Merge pull request #84 from mariadb-corporation/MCOL-1159

MCOL-1159 Merge mariadb-10.2.12

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 201813d63d63e99e50f2474d1bf7d8428ac72119
Merge: 3748036 a002d33
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Fri Jan 19 19:40:18 2018 +0000

Merge pull request #373 from mariadb-corporation/MergeFix

Merge deleted change to include columnstoreversion.h

No longer outputting the messages.

Generated at Thu Feb 08 02:19:41 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.