[MCOL-2230] DATE/TIME type math is broken -- TIMEDIFF, TIMESTAMPDIFF and date math Created: 2019-03-11  Updated: 2019-11-08  Resolved: 2019-11-08

Status: Closed
Project: MariaDB ColumnStore
Component/s: ExeMgr, PrimProc
Affects Version/s: 1.2.2
Fix Version/s: 1.2.5

Type: Bug Priority: Major
Reporter: David Hall (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
PartOf
is part of MCOL-2161 Fix remaining errors in working_tpch1 Closed
Sprint: 2019-04, 2019-05, 2019-06

 Description   

The following regression tests fail:
TIMEDIFF
working_tpch1/qa_fe_cnxFunctions/bug3585.sql
queries return empty
TIMEDIFF.DM
some queries fail
working_tpch1/qa_fe_postProcessedFunctions/TIMEDIFF.DM

TIMESTAMPDIFF
working_tpch1/qa_fe_cnxFunctions/fromunixtime.sql
1 query returns incorrect answer.

DATE math
working_tpch1/qa_fe_cnxFunctions/unix_timestamp.sql

These may or may not be related



 Comments   
Comment by Andrew Hutchings (Inactive) [ 2019-06-10 ]

First 2 are due to an issue in the saturation handling in TIMEDIFF. Second 2 are due to bad result files for the tests. I'll fix all of them as part of this.

Comment by Andrew Hutchings (Inactive) [ 2019-06-10 ]

Pull request in engine and regression suite. Should fix these tests.

Comment by David Hall (Inactive) [ 2019-06-10 ]

Pretty much, if the regression passes, then this is good

Comment by Daniel Lee (Inactive) [ 2019-07-08 ]

Build verified: 1.2.5-1 nightly and regression test suite

server commit:
f44f7d9
engine commit:
4e477ab

[root@localhost regression]# git show
commit 8e788c304db72f6a8b8787b8cfc0ffad068ffcc8
Merge: 3558cbb 68cbfeb
Author: David.Hall <david.hall@mariadb.com>
Date: Fri Jul 5 12:49:46 2019 -0500

Merge pull request #123 from mariadb-corporation/MCOL-3395

MCOL-3395 Add tests for dictionary cache bug

Verified test cases in the bug description

Comment by Roman [ 2019-11-08 ]

The fix doesn't in 1.4

Comment by Roman [ 2019-11-08 ]

Wrong move.

Generated at Thu Feb 08 02:34:43 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.