[MCOL-2110] Cant build engine out-of-source Created: 2019-01-25  Updated: 2019-02-23  Resolved: 2019-02-23

Status: Closed
Project: MariaDB ColumnStore
Component/s: Build
Affects Version/s: 1.2.2
Fix Version/s: 1.2.3

Type: Task Priority: Minor
Reporter: David Mott Assignee: Roman
Resolution: Fixed Votes: 0
Labels: contribution, relnote
Environment:

Ubuntu 16.04, cmake, gcc


Sprint: 2019-01, 2019-02

 Description   

The server's README.md contains a description of out-of-source builds that doesn't work on the engine. This is a preferred method for testing different build configurations since they can be built independently without cleaning and rebuilding the whole project.



 Comments   
Comment by Andrew Hutchings (Inactive) [ 2019-01-25 ]

Can you please provide a little more details with regards to the problems you face?

ben.thompson I believe BuildBot is using out of source builds. Are you aware of any issues with the README.md instructions in the server tree?

Comment by David Mott [ 2019-01-25 ]

pull request 681 was created

Prefixing SERVER_BUILD_INCLUDE_DIR and SERVER_SOURCE_ROOT_DIR with CMAKE_BINARY_DIR works in the case of the engine and server build folders being siblings to each other and relative paths supplied to cmake. If the build folders are not siblings and absolute paths are supplied to cmake it fails. Using GET_FILENAME_COMPONENT will resolve the correct path in both cases.

Comment by Roman [ 2019-02-23 ]

Tested the fix.

Generated at Thu Feb 08 02:33:48 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.