[#MCOL-2001] mscadmin redistributeData parameters are not accepted as suggested by the help information.

[MCOL-2001] mscadmin redistributeData parameters are not accepted as suggested by the help information. Created: 2018-12-07 Updated: 2023-10-26 Resolved: 2019-05-17
Status:	Closed
Project:	MariaDB ColumnStore
Component/s:	?
Affects Version/s:	1.1.6
Fix Version/s:	1.1.0, 1.2.4

Type:

Bug

Priority:

Minor

Reporter:

Ivan Zlatoustov (Inactive)

Assignee:

Daniel Lee (Inactive)

Resolution:

Fixed

Votes:

Labels:

None

Sprint:

2019-01, 2019-02, 2019-03, 2019-04, 2019-05

Description

mcsadmin> redistributeData STATUS
redistributedata Fri Dec 7 12:43:56 2018
redistributeData must have one of START, STOP or STATUS
mcsadmin> redistributeData status
redistributedata Fri Dec 7 12:44:02 2018
WriteEngineServer returned status 3: Redistribute is finished.
0 success, 0 skipped, 0 failed.
Total time: 0 seconds.

mcsadmin> redistributeData START
redistributedata Fri Dec 7 12:49:03 2018
redistributeData must have one of START, STOP or STATUS
mcsadmin> redistributeData start
redistributedata Fri Dec 7 12:49:10 2018
redistributeData START
Source dbroots: 1 2 3
Destination dbroots: 1 2 3

WriteEngineServer returned status 1: Cleared.
WriteEngineServer returned status 2: Redistribute is started.

Comments

Comment by David Hall (Inactive) [ 2019-01-23 ]

Made the parameters for RedistributeData case insensitive.

Comment by Ben Thompson (Inactive) [ 2019-02-04 ]

There was a comment on the github pull request that should be addressed.

Comment by David Hall (Inactive) [ 2019-02-04 ]

Changed the usage from iequals() to strncasecmp (with #ifdef for MSC_VER). This is much more lightweight and we're not dealing with other than ASCII here.

Comment by Daniel Lee (Inactive) [ 2019-02-06 ]

Build tested: 1.1.7-1

server commit:
b5a7a22
engine commit:
1c23dc9

Command is no longer case sensitive, as the ticket requested.

I noticed the following issue. I don't know if it

mcsadmin> redistributeData stop
redistributedata Wed Feb 6 22:14:17 2019
WriteEngineServer returned status 1: Redistribute is not running. Command is ignored.
redistributeData must have one of START, STOP or STATUS

mcsadmin> redistributeData STOP
redistributedata Wed Feb 6 22:15:12 2019
WriteEngineServer returned status 1: Redistribute is not running. Command is ignored.
redistributeData must have one of START, STOP or STATUS

redistributeData START
Source dbroots: 1 2
Destination dbroots: 1 2

WriteEngineServer returned status 1: Cleared.
WriteEngineServer returned status 2: Redistribute is started.
redistributeData must have one of START, STOP or STATUS

The commands are valid. We should not output the last line message

Comment by Daniel Lee (Inactive) [ 2019-05-17 ]

Build verified: 1.1.8-1 nightly
server commit:
01cc1ef
engine commit:
0af6994
Still waiting for 1.2.4-1

Comment by Daniel Lee (Inactive) [ 2019-05-17 ]

Build verified: Github source 1.2.4-1

git commits:

/root/columnstore/mariadb-columnstore-server
commit e3d99393916f0231db02564dd5e316e803bdbbe9
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Mon Jan 14 16:20:01 2019 +0000

Disable Travis triggering on pull requests

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 92d662491ac08095e5998b69a9c730e9d208e8f4
Merge: 0dd33c6 45df72a
Author: Roman Nozdrin <drrtuy@gmail.com>
Date: Thu May 16 21:50:05 2019 +0300

Merge pull request #761 from mariadb-corporation/develop-1.2-merge-up-20190514

Merge develop-1.1 into develop-1.2

Generated at Thu Feb 08 02:32:58 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.

[MCOL-2001] mscadmin redistributeData parameters are not accepted as suggested by the help information. Created: 2018-12-07 Updated: 2023-10-26 Resolved: 2019-05-17