[MCOL-1868] func_concat_ws type Created: 2018-11-09  Updated: 2018-11-15  Resolved: 2018-11-15

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.1.7, 1.2.1
Fix Version/s: 1.1.7, 1.2.2

Type: Bug Priority: Major
Reporter: Andrew Hutchings (Inactive) Assignee: Patrick LeBlanc (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2018-20

 Description   

This is very likely wrong. needs fixing:

string(stringValue(parm[i], row, isNull).c_str(), tmp);



 Comments   
Comment by Andrew Hutchings (Inactive) [ 2018-11-14 ]

Note, there is nothing to QA here since the code is never compiled.

Comment by Patrick LeBlanc (Inactive) [ 2018-11-14 ]

approved it, will merge once 1.2.1 is officially finished.

Comment by Patrick LeBlanc (Inactive) [ 2018-11-15 ]

Just realized the pull request was for develop-1.1. Did you intend for it to go into 1.2 as well?

Comment by Andrew Hutchings (Inactive) [ 2018-11-15 ]

It will go into 1.2 automatically when I do a merge up.

Comment by Patrick LeBlanc (Inactive) [ 2018-11-15 ]

Cool, this is done then.

Comment by Patrick LeBlanc (Inactive) [ 2018-11-15 ]

Nothing to test since the change was in disabled code.

Generated at Thu Feb 08 02:31:59 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.