[MCOL-1844] Allow prior/custom changes made to myCnf-include-args.text be added to new myCnf-include-args.text after upgrading Created: 2018-10-31 Updated: 2020-08-25 Resolved: 2018-11-28 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | None |
| Affects Version/s: | 1.1.6 |
| Fix Version/s: | 1.2.2 |
| Type: | New Feature | Priority: | Minor |
| Reporter: | Chris Calender (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Sprint: | 2018-20 | ||||||||
| Description |
|
Allow for prior/custom changes that have been made to [the original] myCnf-include-args.text be added/included in the new myCnf-include-args.text that is created after upgrading |
| Comments |
| Comment by Patrick LeBlanc (Inactive) [ 2018-11-14 ] |
|
Will include that file in the set saved by the pre-uninstall script. Then will merge the packaged version & the saved version, and continue processing the upgrade. |
| Comment by Patrick LeBlanc (Inactive) [ 2018-11-15 ] |
|
Tested it in develop-1.1, ported it to -1.0 and develop. It's functional but writes a new mycnf-include-args.text file that looks like the following: If they had a comment associated with an entry, it will now be jumbled together at the top with the other comments. If anybody cares about that I can implement it differently. |
| Comment by Patrick LeBlanc (Inactive) [ 2018-11-27 ] |
|
To test... Note, this mod includes a change to the pre-uninstall script, which older versions obviously won't have. It's a one line change, which makes a copy of your mycnf-include.text file so it doesn't get overwritten by the new installation. People upgrading TO this version will have to make the copy by hand. People upgrading FROM this option don't have to do anything. 1) Add an option to your mycnf file (it can be bogus b/c this test doesn't involve running columnstore). So BogusValue=1 |
| Comment by Daniel Lee (Inactive) [ 2018-11-28 ] |
|
QA task for 1.1.7 and 1.0.16 has been moved to a new ticket |
| Comment by Daniel Lee (Inactive) [ 2018-11-28 ] |
|
Build verified: 1.2.2-1 Tests performed: 1) Centos 7 All in all, it is working as expected. Note for localquery setup (1UM2PM) The user only needs to setup the myCnf-include-args.text file on UM1. User customized values are being kept on UM1, and propagated to PMs. |